[OE-core] [thud][PATCH] Revert "OpkgPM: use --add-ignore-recommends to process BAD_RECOMMENDATIONS"

[Quentin Schulz]

Hi all,

On Fri, Oct 18, 2019 at 02:18:15PM -0700, akuster808 wrote:
> 
> 
> On 10/18/19 10:58 AM, Alejandro Del Castillo wrote:
> >
> > On 10/17/19 3:01 PM, Denys Dmytriyenko wrote:
> >> On Thu, Oct 17, 2019 at 12:21:11PM -0700, akuster808 wrote:
> >>> On 10/17/19 11:42 AM, Denys Dmytriyenko wrote:
> >>>> Thank you for this revert! I've been pulling my hair out past couple days
> >>>> figuring out why BAD_RECOMMENDATIONS stopped working for us. This fixed it.
> >>> What I find curious is that the offending commit has been in thud since
> >>> July 29th and we are just now hearing about issues.
> >> Yeah, in our case we only noticed the issue when we started preparing the
> >> latest release and found extra packages that weren't supposed to be there.
> > Is there a bugzilla ticket tracking the issue? 
> I am not aware of any for thud. IIRC, this commit was a backport request
> from the community.
> 
> It would be interesting if those who have issues with thud check against
> master.
> 

Given that I took the patches from 2.7 (warrior) for backport, we should
be safe from that side.

Tested anyway with poky c9a1a608f5146e5dcfebc8e566cb7f6388a3986f
(warrior), and:
1. BAD_RECOMMENDATIONS are not pulled, as intended and expected,
2. the bug I explained in my cover letter[1] as a reason for backporting
the patch Armin has since reverted does not happen,

Quentin

[1] https://lists.yoctoproject.org/g/poky/message/11671
-- 
StreamUnlimited Engineering GmbH
High Tech Campus Vienna, Gutheil-Schoder-Gasse 10, 1100 Vienna, Austria
quentin.schulz at streamunlimited.com, www.streamunlimited.com