[OE-core] [PATCH] meta: add missing some description in devtools

Maxime Roussin-Bélanger maxime.roussinbelanger at gmail.com
Tue Oct 8 02:45:41 UTC 2019


Thanks for the review!

On Mon, Oct 7, 2019 at 2:12 PM Randy MacLeod <randy.macleod at windriver.com>
wrote:

> On 10/2/19 4:52 PM, Maxime Roussin-Bélanger wrote:
> > Signed-off-by: Maxime Roussin-Bélanger <maxime.roussinbelanger at gmail.com
> >
> > ---
> >   meta/recipes-devtools/apt/apt.inc              | 3 +++
> >   meta/recipes-devtools/cmake/cmake.inc          | 6 ++++++
> >   meta/recipes-devtools/dejagnu/dejagnu_1.6.2.bb | 2 ++
> >   meta/recipes-devtools/dnf/dnf_4.2.2.bb         | 5 ++++-
> >   meta/recipes-devtools/meson/meson.inc          | 3 +++
> >   meta/recipes-devtools/qemu/qemu.inc            | 4 ++++
> >   meta/recipes-devtools/quilt/quilt.inc          | 4 ++++
> >   meta/recipes-devtools/swig/swig.inc            | 3 +++
> >   meta/recipes-devtools/unfs3/unfs3_git.bb       | 3 +++
> >   9 files changed, 32 insertions(+), 1 deletion(-)
>
> Thanks for the updates Maxime. I have a few minor fixes/questions.
> >
> > diff --git a/meta/recipes-devtools/apt/apt.inc
> b/meta/recipes-devtools/apt/apt.inc
> > index b855099e52..6883ac865a 100644
> > --- a/meta/recipes-devtools/apt/apt.inc
> > +++ b/meta/recipes-devtools/apt/apt.inc
> > @@ -1,4 +1,7 @@
> >   SUMMARY = "Advanced front-end for dpkg"
> > +DESCRIPTION = "Provides commandline tools for searching and managing as
> well \
> s/commandline/command-line/
> according to:
>     https://en.wikipedia.org/wiki/Command-line_interface
>     https://wiki.debian.org/Apt
>
> > +as querying information about packages as a low-level access to all
> features \
> > +of the libapt-pkg library."
> >   LICENSE = "GPLv2.0+"
> >   SECTION = "base"
> >
> > diff --git a/meta/recipes-devtools/cmake/cmake.inc
> b/meta/recipes-devtools/cmake/cmake.inc
> > index 3711f18db6..35d78eea17 100644
> > --- a/meta/recipes-devtools/cmake/cmake.inc
> > +++ b/meta/recipes-devtools/cmake/cmake.inc
> > @@ -2,6 +2,12 @@
> >   # Released under the MIT license (see packages/COPYING)
> >
> >   SUMMARY = "Cross-platform, open-source make system"
> > +DESCRIPTION = "CMake is used to control the software compilation
> process \
> > +using simple platform and compiler independent configuration files.
> CMake \
> > +generates native makefiles and workspaces that can be used in the
> compiler \
> > +environment of your choice.
> Should we cut off the text here?
>

Probably... after rereading I feel this is extra text and it doesn't add
much.


> > CMake is quite sophisticated: it is possible to \
> > +support complex environments requiring system configuration,
> pre-processor \
> > +generation, code generation, and template instantiation."
> >   HOMEPAGE = "http://www.cmake.org/"
> >   BUGTRACKER = "http://public.kitware.com/Bug/my_view_page.php"
> >   SECTION = "console/utils"
> > diff --git a/meta/recipes-devtools/dejagnu/dejagnu_1.6.2.bb
> b/meta/recipes-devtools/dejagnu/dejagnu_1.6.2.bb
> > index 7dc4e417f6..10220ebc91 100644
> > --- a/meta/recipes-devtools/dejagnu/dejagnu_1.6.2.bb
> > +++ b/meta/recipes-devtools/dejagnu/dejagnu_1.6.2.bb
> > @@ -1,4 +1,6 @@
> >   SUMMARY = "GNU unit testing framework, written in Expect and Tcl"
> > +DESCRIPTION = "DejaGnu is a framework for testing other programs. Its
> purpose \
> > +is to provide a single front end for all tests."
> >   LICENSE = "GPLv2"
> >   LIC_FILES_CHKSUM =
> "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
> >   SECTION = "devel"
> > diff --git a/meta/recipes-devtools/dnf/dnf_4.2.2.bb
> b/meta/recipes-devtools/dnf/dnf_4.2.2.bb
> > index c77773332c..f38167f1ad 100644
> > --- a/meta/recipes-devtools/dnf/dnf_4.2.2.bb
> > +++ b/meta/recipes-devtools/dnf/dnf_4.2.2.bb
> > @@ -1,4 +1,7 @@
> >   SUMMARY = "Package manager forked from Yum, using libsolv as a
> dependency resolver"
> > +DESCRIPTION = "Software package manager that installs, updates, and
> removes \
> > +packages on RPM-based Linux distributions. It automatically computes \
> > +dependencies and determines the actions required to install packages."
> >   LICENSE = "GPLv2"
> >   LIC_FILES_CHKSUM =
> "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
> >
>  file://PACKAGE-LICENSING;md5=4a0548e303dbc77f067335b4d688e745 \
> > @@ -71,7 +74,7 @@ do_install_append_class-native() {
> >   do_install_append_class-nativesdk() {
> >           create_wrapper ${D}/${bindir}/dnf \
> >                   RPM_CONFIGDIR=${SDKPATHNATIVE}${libdir_nativesdk}/rpm \
> > -                RPM_NO_CHROOT_FOR_SCRIPTS=1
> > +                RPM_NO_CHROOT_FOR_SCRIPTS=1
> Whitespace only? Ah, you removed a trailing space.
> Please add:
>    Remove trailing space in dnf recipe.
> in the log to prevent OCDers from wondering if there was a typo.
>

I was not intending to submit this change.

Your comment means to submit a 2 part patch with this change right?


> >   }
> >
> >   SYSTEMD_SERVICE_${PN} = "dnf-makecache.service dnf-makecache.timer \
> > diff --git a/meta/recipes-devtools/meson/meson.inc
> b/meta/recipes-devtools/meson/meson.inc
> > index 6de109de7f..2958a2a8de 100644
> > --- a/meta/recipes-devtools/meson/meson.inc
> > +++ b/meta/recipes-devtools/meson/meson.inc
> > @@ -1,5 +1,8 @@
> >   HOMEPAGE = "http://mesonbuild.com"
> >   SUMMARY = "A high performance build system"
> > +DESCRIPTION = "Meson is a build system designed to increase programmer \
> > +productivity. It does this by providing a fast, simple and easy to use \
> > +interface for modern software development tools and practices."
> >
> >   LICENSE = "Apache-2.0"
> >   LIC_FILES_CHKSUM =
> "file://COPYING;md5=3b83ef96387f14655fc854ddc3c6bd57"
> > diff --git a/meta/recipes-devtools/qemu/qemu.inc
> b/meta/recipes-devtools/qemu/qemu.inc
> > index de21d30732..11783eaca5 100644
> > --- a/meta/recipes-devtools/qemu/qemu.inc
> > +++ b/meta/recipes-devtools/qemu/qemu.inc
> > @@ -1,4 +1,8 @@
> >   SUMMARY = "Fast open source processor emulator"
> > +DESCRIPTION = "QEMU is a hosted virtual machine monitor: it emulates
> the \
> > +machine's processor through dynamic binary translation and provides a
> set \
> > +of different hardware and device models for the machine, enabling it to
> run \
> > +a variety of guest operating systems"
> >   HOMEPAGE = "http://qemu.org"
> >   LICENSE = "GPLv2 & LGPLv2.1"
> >
> > diff --git a/meta/recipes-devtools/quilt/quilt.inc
> b/meta/recipes-devtools/quilt/quilt.inc
> > index 433e9b40b7..61e1c93605 100644
> > --- a/meta/recipes-devtools/quilt/quilt.inc
> > +++ b/meta/recipes-devtools/quilt/quilt.inc
> > @@ -1,4 +1,8 @@
> >   SUMMARY = "Tool for working with series of patches"
> > +DESCRIPTION = "Quilt is a tool to manage large sets of patches by
> keeping \
> > +track of the changes each patch makes. Patches can be applied,
> un-applied,\
> > +refreshed, etc.
> End here as is done:
>     http://savannah.nongnu.org/projects/quilt/
> > The key philosophical concept is that your primary output \
> > +is patches."


> Thanks again for the updates.
> ../Randy
>
> >   HOMEPAGE = "http://savannah.nongnu.org/projects/quilt/"
> >   SECTION = "devel"
> >   LICENSE = "GPLv2"
> > diff --git a/meta/recipes-devtools/swig/swig.inc
> b/meta/recipes-devtools/swig/swig.inc
> > index 00b9c5b605..e62718c508 100644
> > --- a/meta/recipes-devtools/swig/swig.inc
> > +++ b/meta/recipes-devtools/swig/swig.inc
> > @@ -1,4 +1,7 @@
> >   SUMMARY = "SWIG - Simplified Wrapper and Interface Generator"
> > +DESCRIPTION = "SWIG is a compiler that makes it easy to integrate C and
> C++ \
> > +code with other languages including Perl, Tcl, Ruby, Python, Java,
> Guile, \
> > +Mzscheme, Chicken, OCaml, Pike, and C#."
> >   HOMEPAGE = "http://swig.sourceforge.net/"
> >   LICENSE = "BSD & GPLv3"
> >   LIC_FILES_CHKSUM =
> "file://LICENSE;md5=e7807a6282784a7dde4c846626b08fc6 \
> > diff --git a/meta/recipes-devtools/unfs3/unfs3_git.bb
> b/meta/recipes-devtools/unfs3/unfs3_git.bb
> > index a4ac46c68e..79d09788d3 100644
> > --- a/meta/recipes-devtools/unfs3/unfs3_git.bb
> > +++ b/meta/recipes-devtools/unfs3/unfs3_git.bb
> > @@ -1,4 +1,7 @@
> >   SUMMARY = "Userspace NFS server v3 protocol"
> > +DESCRIPTION = "UNFS3 is a user-space implementation of the NFSv3 server
> \
> > +specification. It provides a daemon for the MOUNT and NFS protocols,
> which \
> > +are used by NFS clients for accessing files on the server."
> >   SECTION = "console/network"
> >   LICENSE = "unfs3"
> >   LIC_FILES_CHKSUM =
> "file://LICENSE;md5=9475885294e17c0cc0067820d042792e"
> >
>
>
> --
> # Randy MacLeod
> # Wind River Linux
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20191007/b71ab12a/attachment.html>


More information about the Openembedded-core mailing list