[OE-core] [OE-Core][master][PATCH] menuconfig: Add mechanism for user to append to same devtool fragment after user runs finish

[Paul Eggleton]

Hi Chandana,

On Tuesday, 8 October 2019 7:14:18 AM NZDT Sai Hari Chandana Kalluri wrote:
> In current devtool flow, if user runs devtool modify, menuconfig and
> finish, it will create a devtool-fragment.cfg and append to SRC_URI of
> the recipe.
> 
> When a user runs the same flow multiple times, the devtool-fragment.cfg
> created in previous iteration gets replaced with the new fragment
> created in the current iteration. As a result, user can lose config
> changes made previously.
> 
> Provide menuconfig with an option -a or --allow-append that lets users
> to continue append to previous iteration of devtool-fragment.cfg.
> 	Ex. devtool menuconfig linux-xlnx -a
> 
> By default, the devtool flow will replace the config fragment unless
> specified with the -a option.

Functionality-wise his change looks reasonable. However I think it might be 
worth taking a step back and seeing if there is a way we can improve the 
workflow here. I think it's possible that you might want to create several 
config fragments for different features (which would of course need their own 
names), would you agree? If so I think you would want to be able to specify 
the fragment name, but even if it wasn't specified it should auto-generate a 
new name each time rather than hard-coding devtool-fragment.cfg. If it's 
smart, it could allow editing fragments in the middle of a stack of multiple 
fragments, but that would be a bonus.

As for the code itself, could you please (a) ensure you use PEP-8 compliant 
spacing and four-space indentation everywhere and (b) don't undo changes that 
were made to the code when it was merged - I could be wrong but it looks to me 
as if you started with an earlier version of the file. If in doubt please 
review the patch before sending and make sure it is only making changes that 
you expect it to.

Thanks
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre