[OE-core] [PATCH v2] systemd.bbclass: enable all services specified in ${SYSTEMD_SERVICE}

Mikko Rapeli mikko.rapeli at bmw.de
Thu Oct 17 07:31:58 UTC 2019


This has been the traditional way of enabling systemd services.
It may conflict with presets feature, but other layers, image classes
and recipes add services to be enabled using SYSTEMD_SERVICE
variable also with read-only rootfs, e.g. IMAGE_FEATURES has
stateless-rootfs and systemd_preset_all task is not executed.

Fixes startup of custom services from our recipes using custom
image classes with various BSP layers. In the worst case even
serial console getty service wasn't starting due to dependency
no not enabled services.

Signed-off-by: Mikko Rapeli <mikko.rapeli at bmw.de>
Cc: Peter Kjellerstedt <peter.kjellerstedt at axis.com>
---
 meta/classes/systemd.bbclass | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

v2: simplified according to comments in
http://lists.openembedded.org/pipermail/openembedded-core/2019-October/288032.html

v1: http://lists.openembedded.org/pipermail/openembedded-core/2019-October/288031.html

diff --git a/meta/classes/systemd.bbclass b/meta/classes/systemd.bbclass
index 1dca099..9e8a82c 100644
--- a/meta/classes/systemd.bbclass
+++ b/meta/classes/systemd.bbclass
@@ -32,11 +32,7 @@ if type systemctl >/dev/null 2>/dev/null; then
 
 	if [ "${SYSTEMD_AUTO_ENABLE}" = "enable" ]; then
 		for service in ${SYSTEMD_SERVICE_ESCAPED}; do
-			case "${service}" in
-			*@*)
-				systemctl ${OPTS} enable "${service}"
-				;;
-			esac
+			systemctl ${OPTS} enable "$service"
 		done
 	fi
 
-- 
1.9.1



More information about the Openembedded-core mailing list