[OE-core] [warrior][PATCH 7/8] devtool: finish: Add suppport for the --no-clean option

[Peter Kjellerstedt]

> -----Original Message-----
> From: akuster808 <akuster808 at gmail.com>
> Sent: den 16 oktober 2019 22:25
> To: Peter Kjellerstedt <peter.kjellerstedt at axis.com>; openembedded-
> core at lists.openembedded.org
> Subject: Re: [OE-core] [warrior][PATCH 7/8] devtool: finish: Add
> suppport for the --no-clean option
> 
> On 10/16/19 9:30 AM, Peter Kjellerstedt wrote:
> > From: Peter Kjellerstedt <peter.kjellerstedt at axis.com>
> >
> > This works just like the already existing --no-clean option to the
> > `devtool reset` command.
> what problem is this solving in warrior?
> -a rmin

Keeping the development tools in sync with master so one can use the 
same options when working regardless of if one is working with Warrior 
or Zeus. Since it does not affect what is built and goes into the rootfs, 
it should not be a problem that it technically is a new feature.

//Peter

> >
> > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt at axis.com>
> > Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> > ---
> >  scripts/lib/devtool/standard.py | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/lib/devtool/standard.py
> b/scripts/lib/devtool/standard.py
> > index b944ec3966..aeb9452a8a 100644
> > --- a/scripts/lib/devtool/standard.py
> > +++ b/scripts/lib/devtool/standard.py
> > @@ -1895,7 +1895,7 @@ def finish(args, config, basepath, workspace):
> >          else:
> >              raise DevtoolError('Source tree is not
> clean:\n\n%s\nEnsure you have committed your changes or use -f/--force
> if you are sure there\'s nothing that needs to be committed' % dirty)
> >
> > -    no_clean = False
> > +    no_clean = args.no_clean
> >      tinfoil = setup_tinfoil(basepath=basepath, tracking=True)
> >      try:
> >          rd = parse_recipe(config, tinfoil, args.recipename, True)
> > @@ -2169,6 +2169,7 @@ def register_commands(subparsers, context):
> >      parser_finish.add_argument('--mode', '-m', choices=['patch',
> 'srcrev', 'auto'], default='auto', help='Update mode (where %(metavar)s
> is %(choices)s; default is %(default)s)', metavar='MODE')
> >      parser_finish.add_argument('--initial-rev', help='Override
> starting revision for patches')
> >      parser_finish.add_argument('--force', '-f', action="store_true",
> help='Force continuing even if there are uncommitted changes in the
> source tree repository')
> > +    parser_finish.add_argument('--no-clean', '-n',
> action="store_true", help='Don\'t clean the sysroot to remove recipe
> output')
> >      parser_finish.add_argument('--no-overrides', '-O',
> action="store_true", help='Do not handle other override branches (if
> they exist)')
> >      parser_finish.add_argument('--dry-run', '-N',
> action="store_true", help='Dry-run (just report changes instead of
> writing them)')
> >      parser_finish.add_argument('--force-patch-refresh',
> action="store_true", help='Update patches in the layer even if they
> have not been modified (useful for refreshing patch context)')