[OE-core] [zeus 18/28] cmake.bbclass: add HOSTTOOLS_DIR to CMAKE_FIND_ROOT_PATH

[akuster808]

On 10/29/19 9:31 PM, Khem Raj wrote:
>
>
> On Tue, Oct 29, 2019 at 9:19 AM Richard Purdie
> <richard.purdie at linuxfoundation.org
> <mailto:richard.purdie at linuxfoundation.org>> wrote:
>
>     On Fri, 2019-10-25 at 23:49 -0700, Armin Kuster wrote:
>     > From: Michael Ho <Michael.Ho at bmw.de <mailto:Michael.Ho at bmw.de>>
>     >
>     > The find_program command will fail if it is used on a tool that is
>     > listed in
>     > ASSUME_PROVIDED. This is because these tools are in the hosttools
>     > directory
>     > which is not listed in CMAKE_FIND_ROOT_PATH so cmake will not find
>     > them.
>     >
>     > Adding the directory HOSTTOOLS_DIR to the CMAKE_FIND_ROOT_PATH
>     > variable fixes
>     > the initial issue of needing to search for tools in ASSUME_PROVIDED.
>     >
>     > Note that this change alone does not fix the issue because
>     > find_program will
>     > by default only look into the subdirectories bin and usr/bin under
>     > the paths
>     > in CMAKE_FIND_ROOT_PATH to find the programs and the hosttools
>     > directory has
>     > instead the symlinks directly present without these subdirectories.
>     >
>     > Set CMAKE_PROGRAM_PATH to by default include the root directory so
>     > find_program can search the hosttools directory without needing the
>     > prefix
>     > directories.
>     >
>     > Signed-off-by: Ross Burton <ross.burton at intel.com
>     <mailto:ross.burton at intel.com>>
>     > (cherry picked from commit 7847f431cd8db59fce8c9401a603c4b0678ee16d)
>     > Signed-off-by: Armin Kuster <akuster808 at gmail.com
>     <mailto:akuster808 at gmail.com>>
>
>     Given the fallout in meta-oe, I don't plan to take this.
>
>  
> +1

So is this why to took me on a 3 mile walk up a hill?


>
>
>     Cheers,
>
>     Richard
>
>     -- 
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core at lists.openembedded.org
>     <mailto:Openembedded-core at lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20191030/c38b2c63/attachment.html>