[OE-core] [PATCH 2/2] gcc-cross: Fix header file corruption problems

[Khem Raj]

On Fri, Sep 6, 2019 at 7:23 AM <richard.purdie at linuxfoundation.org> wrote:

> On Fri, 2019-09-06 at 07:15 -0700, Khem Raj wrote:
> >
> >
> > On Fri, Sep 6, 2019 at 12:24 AM Richard Purdie <
> > richard.purdie at linuxfoundation.org> wrote:
> > > gcc's makefile can move files, replacing with the contents
> > > "timestamp". This
> > > corrupts the headers and breaks things like the gcc testsuite.
> > >
> > > Add in a fix to ensure the headers are not corrupted through their
> > > hardlink copies.
> > >
> > > Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> > > ---
> > >  meta/recipes-devtools/gcc/gcc-cross.inc | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc
> > > b/meta/recipes-devtools/gcc/gcc-cross.inc
> > > index e417b898734..95af6d89a9d 100644
> > > --- a/meta/recipes-devtools/gcc/gcc-cross.inc
> > > +++ b/meta/recipes-devtools/gcc/gcc-cross.inc
> > > @@ -212,6 +212,9 @@ do_gcc_stash_builddir[cleandirs] =
> > > "${BUILDDIRSTASH}"
> > >  do_gcc_stash_builddir () {
> > >         dest=${BUILDDIRSTASH}
> > >         hardlinkdir . $dest
> > > +       # Makefile does move-if-change which can end up with
> > > 'timestamp' as file contents so break links to those files
> > > +       rm $dest/gcc/include/*.h
> > > +       cp gcc/include/*.h $dest/gcc/include/
> > >  }
> >
> > I think we moved them outside gcc dir isn’t it
>
> Not sure I follow? I think the patch is correct?
>

Yeah I think patch is fine since I was wondering about files from
gcc-runtime which got move

>
> Cheers,
>
> Richard
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20190906/9c9eb4fa/attachment.html>