[OE-core] [PATCH] glibc-testsuite: SkipRecipe if libc is not glibc

Peter Kjellerstedt peter.kjellerstedt at axis.com
Fri Sep 13 17:32:00 UTC 2019


> -----Original Message-----
> From: Khem Raj <raj.khem at gmail.com>
> Sent: den 13 september 2019 15:48
> To: Nathan Rossi <nathan at nathanrossi.com>
> Cc: Patches and discussions about the oe-core layer <openembedded-
> core at lists.openembedded.org>; Peter Kjellerstedt
> <peter.kjellerstedt at axis.com>
> Subject: Re: [OE-core] [PATCH] glibc-testsuite: SkipRecipe if libc is
> not glibc
> 
> On Fri, Sep 13, 2019 at 12:49 AM Nathan Rossi <nathan at nathanrossi.com>
> wrote:
> >
> > To prevent issues with parsing or dependencies, limit this recipe to
> use
> > only when the libc is glibc (and libc-locale is glibc-locale).
> >
> > Signed-off-by: Nathan Rossi <nathan at nathanrossi.com>
> > ---
> >  meta/recipes-core/glibc/glibc-testsuite_2.30.bb | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/meta/recipes-core/glibc/glibc-testsuite_2.30.bb
> b/meta/recipes-core/glibc/glibc-testsuite_2.30.bb
> > index 64fa8d87df..657fd4dbc1 100644
> > --- a/meta/recipes-core/glibc/glibc-testsuite_2.30.bb
> > +++ b/meta/recipes-core/glibc/glibc-testsuite_2.30.bb
> > @@ -8,6 +8,13 @@ PROVIDES = ""
> >  # setup depends
> >  INHIBIT_DEFAULT_DEPS = ""
> >
> > +python () {
> > +    libc = d.getVar("PREFERRED_PROVIDER_virtual/libc")
> > +    libclocale = d.getVar("PREFERRED_PROVIDER_virtual/libc-locale")
> > +    if libc != "glibc" or libclocale != "glibc-locale":
> > +        raise bb.parse.SkipRecipe("glibc-testsuite requires that virtual/libc is glibc")
> > +}
> > +
> would something like below work
> 
> COMPATIBLE_HOST ?= "null"
> COMAPTIBLE_HOST_libc-glibc = "(*)"

No, that will not work. The glibc we use is still glibc, even if it is not 
the version from OE-Core. Thus the libc-glibc override is active also in 
our case.

> >  DEPENDS += "glibc-locale libgcc gcc-runtime"
> >
> >  # remove the initial depends
> > ---
> > 2.23.0

I'll be back when I have had time to test the suggested patch.

//Peter



More information about the Openembedded-core mailing list