[OE-core] [PATCH 1/2] mdadm: fix do_package failed when changed local.conf but not cleaned

[Changqing Li]

On 9/7/19 5:48 AM, Richard Purdie wrote:
> On Fri, 2019-09-06 at 11:37 +0800, changqing.li at windriver.com wrote:
>> From: Changqing Li <changqing.li at windriver.com>
>>
>> reproduce steps:
>> 1. add DISTRO_FEATURE_append = 'usrmerge' in local.conf
>> 2. bitbake mdadm --success
>> 3. remove DISTRO_FEATURE_append = 'usrmerge' from local.conf
>> 4. bitbake mdadm  -- failed when do_package
>>
>> it is not proper to change source Makefile during do_install by sed,
>> change to add patch for it.
>>
>> [YOCTO #13493]
>>
>> Signed-off-by: Changqing Li <changqing.li at windriver.com>
> This somehow seems to break:
>
> oe-selftest -r devtool.DevtoolModifyTests.test_devtool_buildclean
> and
> oe-selftest -r devtool.DevtoolModifyTests.test_devtool_modify
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/56/builds/694
>
> Cheers,
>
> Richard

I researched this problem,  it is not problem of this patch, but this 
patch reveal

the defect of the testcase.


without this patch, Makefile is changed during first run of do_compile 
task,

for external_src, EXTERNALSRC is one of inputs of sigdata of do_compile,

then will rerun the second time's compile task.  but this cover defects 
of testcase,

please see the fixed patch for details.


I have send 2 patch to fix the problem of testcase,  which is titled 
with devtool.py


BRs

Sandy

>
>
>