[OE-core] [PATCH v2] glibc: don't ignore global LDFLAGS settings

[Rasmus Villemoes]

ping

On 20/01/2020 16.42, Khem Raj wrote:
> this patch is ok but I have reservations since  += now means global
> ldflags will be applied
> so it would need some testing to ensure it works well.
> 
> On Mon, Jan 20, 2020 at 1:23 AM Rasmus Villemoes
> <rasmus.villemoes at prevas.dk> wrote:
>>
>> Two things: The -Wl,-rpath-link comment is stale (due to per-recipe
>> staging), so we no longer need to set our own LDFLAGS to avoid
>> -Wl,-rpath-link being in there. Second, overriding LDFLAGS should be
>> done at the recipe level so "bitbake -e" can show what is going on.
>> Otherwise debugging why one's global LDFLAGS tweaks are being ignored
>> is needlessly painful.
>>
>> So pull out the LDFLAGS setting from do_compile, and change it to an
>> append instead of assignment.
>>
>> For the benefit of future git blame: the -fuse-ld=bfd setting was
>> added by ac64c3b96b (glibc: always use bfd linker).
>>
>> Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
>> ---
>> v2: Rebase to real upstream master. Note to self: "git pull" before rebasing to master.
>>
>>  meta/recipes-core/glibc/glibc_2.31.bb | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-core/glibc/glibc_2.31.bb b/meta/recipes-core/glibc/glibc_2.31.bb
>> index b8c570db52..cfba4de49b 100644
>> --- a/meta/recipes-core/glibc/glibc_2.31.bb
>> +++ b/meta/recipes-core/glibc/glibc_2.31.bb
>> @@ -93,9 +93,8 @@ do_configure () {
>>          CPPFLAGS="" oe_runconf
>>  }
>>
>> +LDFLAGS += "-fuse-ld=bfd"
>>  do_compile () {
>> -       # -Wl,-rpath-link <staging>/lib in LDFLAGS can cause breakage if another glibc is in staging
>> -       LDFLAGS="-fuse-ld=bfd"
>>         base_do_compile
>>         echo "Adjust ldd script"
>>         if [ -n "${RTLDLIST}" ]
>> --
>> 2.23.0
>>


-- 
Rasmus Villemoes
Software Developer
Prevas A/S
Hedeager 3
DK-8200 Aarhus N
+45 51210274
rasmus.villemoes at prevas.dk
www.prevas.dk