[OE-core] [PATCH] swuashfs-tools: Enable on musl

[Adrian Bunk]

On Fri, Feb 14, 2020 at 06:42:12AM -0800, Khem Raj wrote:
> On Fri, Feb 14, 2020 at 6:35 AM Adrian Bunk <bunk at stusta.de> wrote:
> >
> > On Thu, Feb 13, 2020 at 11:03:52PM -0800, Khem Raj wrote:
> > > Upstream has a patch [1] to fix musl builds, Prior to this it would not
> > > build on musl due to missing GNU extentions for fnmatch
> > >
> > > [1] https://github.com/plougher/squashfs-tools/commit/4280e74de14070869787a9166242f9ce2dafd82e
> > >...
> >
> > I did already remove a similar bogus squashfs-tools change from OE,
> > with similar FNM_EXTMATCH "fixes" in ifupdown and elfutils
> > also resulting in the expected runtime misbehaviour.
> 
> I think it would be better to use gnulib implementation for these
> packages you point out
> and those patches will be upstream worthy and make them portable
> as well.

Yes, this would be better since the resulting code would be working.

But looking at the gnulib sources someone made gl_FUNC_FNMATCH_GNU do 
the wrong thing by "guessing yes" when cross-compiling for musl...

> At least it is calling out bad elements.

The only bad element is code that builds but silently does the wrong 
thing. Everything else is visible for users early during product
development and can be mitigated.

cu
Adrian