[OE-core] [PATCH 02/10] procps: upstream has switched to gitlab

[Khem Raj]

Ok, thanks. for confirmation

On Mon, Feb 17, 2020 at 12:12 AM Alexander Kanavin
<alex.kanavin at gmail.com> wrote:
>
> I looked it up. Actually, potfiles.in is typically not a generated file, and should be placed under version control. The comment is valid.
>
> Alex
>
> On Mon 17. Feb 2020 at 3.36, Khem Raj <raj.khem at gmail.com> wrote:
>>
>> On Sun, Feb 16, 2020 at 12:45 PM Alexander Kanavin
>> <alex.kanavin at gmail.com> wrote:
>> >
>> > On Sun, 16 Feb 2020 at 21:07, Khem Raj <raj.khem at gmail.com> wrote:
>> >>
>> >> >>> -S = "${WORKDIR}/procps-ng-${PV}"
>> >> >>> +# Upstream has a custom autogen.sh which invokes po/update-potfiles as they
>> >> >>> +# don't ship a po/POTFILES.in (which is silly).  Without that file gettext
>> >> >>> +# doesn't believe po/ is a gettext directory and won't generate po/Makefile.
>> >> >>
>> >> >> Do we miss .in file from tarball ? Or is it missing in a git checkout
>> >> >> This is expected when building in a maintainer mode
>> >> >> Tarballs are produced by maintainers for users
>> >> >> Who wants to build from source
>> >> >
>> >> >
>> >> > The .in is available in tarballs, but not in git repo. It's generated as explained above.
>> >>
>> >> right. Then revise the comment, since its expected to be absent when
>> >> we are building from
>> >> git sources.
>> >
>> >
>> > The fix and the comment were copied wholesale and were originally written by Ross. How is POTFILES.in normally generated (i.e. without involving custom autogen.sh)?
>>
>> any .in file is usually generated by maintainer into source tarball
>> since the build is not consuming source tar anymore
>> this comment perhaps should be deleted.
>>
>> >
>> > Alex