[OE-core] [meta-oe] [PATCH 1/1] fio: remove disabling of compiler optimizations

[Andre McCurdy]

On Tue, Feb 18, 2020 at 12:32 PM Jonathan Richardson via
Openembedded-core <openembedded-core at lists.openembedded.org> wrote:
>
> Disabling compiler optimizations affects fio performance by 25-30% so
> remove this from EXTRA_OECONF. Disabling of optimizations should be
> machine specific if there are bugs in the code instead of the default.

Wrong mailing list ( patches for meta-oe should be sent to
openembedded-devel at lists.openembedded.org )

In general when removing a workaround or fix it's also helpful to
include a link to the commit which added it, in this case:

  https://git.openembedded.org/meta-openembedded/commit/?id=739349da0826221f98648b64b693f9ae33e7d4ea

(FWIW since that crash was seen with a much older version of fio
compiled with a now obsolete toolchain it seems perfectly justified to
remove it).

> Signed-off-by: Jonathan Richardson <jonathan.richardson at broadcom.com>
> ---
>  meta-oe/recipes-benchmark/fio/fio_3.18.bb | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/meta-oe/recipes-benchmark/fio/fio_3.18.bb b/meta-oe/recipes-benchmark/fio/fio_3.18.bb
> index b6484290f..2c461b8c5 100644
> --- a/meta-oe/recipes-benchmark/fio/fio_3.18.bb
> +++ b/meta-oe/recipes-benchmark/fio/fio_3.18.bb
> @@ -33,7 +33,6 @@ S = "${WORKDIR}/git"
>  DISABLE_STATIC = ""
>
>  EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'"
> -EXTRA_OECONF = "--disable-optimizations"
>
>  do_configure() {
>      ./configure ${EXTRA_OECONF}
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core