[OE-core] [PATCH v2] gstreamer1.0-plugins-good: change EXTRA_OECONF -> EXTRA_OEMESON

Mittal, Anuj anuj.mittal at intel.com
Wed Feb 19 02:43:16 UTC 2020


On Tue, 2020-02-18 at 18:39 -0800, Khem Raj wrote:
> On Tue, Feb 18, 2020 at 6:37 PM Anuj Mittal <anuj.mittal at intel.com>
> wrote:
> > Use the correct variable so options actually get used and use the
> > correct qt option name to prevent errors.
> > 
> > Signed-off-by: Anuj Mittal <anuj.mittal at intel.com>
> > ---
> >  .../gstreamer/gstreamer1.0-plugins-good_1.16.1.bb             | 4
> > ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-
> > plugins-good_1.16.1.bb b/meta/recipes-
> > multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb
> > index a6eb9986dd..07a0bf5085 100644
> > --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-
> > good_1.16.1.bb
> > +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-
> > good_1.16.1.bb
> > @@ -55,7 +55,7 @@ PACKAGECONFIG[x11]        =
> > "${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}"
> >  # This is better done in a separate qt5 layer (which then should
> > add a "qt5" packageconfig
> >  # in a gstreamer1.0-plugins-good bbappend).
> > 
> > -EXTRA_OECONF += " \
> > +EXTRA_OEMESON += " \
> >      -Daalib=disabled \
> >      -Ddirectsound=disabled \
> >      -Ddv=disabled \
> > @@ -64,7 +64,7 @@ EXTRA_OECONF += " \
> >      -Doss4=disabled \
> >      -Dosxaudio=disabled \
> >      -Dosxvideo=disabled \
> > -    -Dqt=disabled \
> > +    -Dqt5=disabled \
> 
> this perhaps should be a packageconfig so people using meta-qt5 can
> enable it

Yes probably but in a separate change I think. This just ensures that
the right options are used and nothing else is changed.

Thanks,

Anuj

> 
> >      -Dshout2=disabled \
> >      -Dtwolame=disabled \
> >      -Dwaveform=disabled \
> > --
> > 2.24.1
> > 
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core


More information about the Openembedded-core mailing list