[OE-core] [PATCH 3/3] oeqa/selftest: Drop 'backup' code and SIGTERM handler

[Peter Kjellerstedt]

> -----Original Message-----
> From: openembedded-core-bounces at lists.openembedded.org <openembedded-core-bounces at lists.openembedded.org> On Behalf Of Richard Purdie
> Sent: den 19 februari 2020 19:38
> To: openembedded-core at lists.openembedded.org
> Subject: [OE-core] [PATCH 3/3] oeqa/selftest: Drop 'backup' code and SIGTERM handler
> 
> Now selftest is using its own copied build directory, we can stop worrying about
> copying files around as backup, and drop the SIGTERM handler to try and restore
> them, simplifying the code.
> 
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> ---
>  meta/lib/oeqa/selftest/case.py    | 30 +-------------------
>  meta/lib/oeqa/selftest/context.py | 47 ++-----------------------------
>  2 files changed, 4 insertions(+), 73 deletions(-)

[cut]

> @@ -329,18 +311,9 @@ class
> OESelftestTestContextExecutor(OETestContextExecutor):
> 
>          return rc
> 
> -    def _signal_clean_handler(self, signum, frame):
> -        if self.ourpid == os.getpid():
> -            sys.exit(1)
> -
>      def run(self, logger, args):
>          self._process_args(logger, args)
> 
> -        # Setup a SIGTERM handler to allow restoration of files like local.conf and bblayers.conf
> -        # but don't interfer with other processes
> -        self.ourpid = os.getpid()
> -        signal.signal(signal.SIGTERM, self._signal_clean_handler)
> -

What's the point of the first patch in this series, when you just 
remove it all again here in the third patch?

>          rc = None
>          try:
>              if args.machine:

//Peter