[OE-core] [PATCH] wic: Add include-dir option

[akuster808]

Paul,


On 2/27/20 11:50 AM, Paul Barker wrote:
> On Thu, 27 Feb 2020 at 19:43, akuster808 <akuster808 at gmail.com> wrote:
>>
>>
>> On 2/27/20 12:12 AM, Martin Hundebøll wrote:
>>> Hi Armin,
>>>
>>> On 27/02/2020 05.26, Armin Kuster wrote:
>>>> This option allows for the inclusion of a single directory
>>>> for a partition.
>>> I am unsure how this is used in a .wks file.
>> Yeah, the documentation does not cover this.
>>
>> This is what I used to verified it works
>>
>> part  / --source rootfs --ondisk mmcblk1 --fstype=ext4 --label rootfs
>> --align 4096 --exclude-path=var
>> part  /var --source rootfs --ondisk mmcblk1 --fstype=ext4 --label var
>> --align 4096 --include-dir=var
>>
>>
>>> From the code it looks similar to the include-path option, but
>>> relative to the rootfs source dir instead of the wic working dir?
>> the --include-path adds an entire rootfs  to the partition. I don't want
>> the another rootfs. The help file even says that.  I want on directory.
>> --exclude-dir allows me to "exclude" a dir .
>>
>>
>> I used wic ls {path to partition}:{partition number}  to view the
>> contents  of the partition.
>>
>>> But the include-dir value is also used in the destination path?
>> Then please document it and I don't mean the "help" file which is unclear.
>>
>> So how would you have "home" or "var" be in their own partitions? Please
>> show an example.
> IIRC,
>
> part  / --source rootfs --ondisk mmcblk1 --fstype=ext4 --label rootfs
> --align 4096 --exclude-path=var
> part  /var --source rootfs --ondisk mmcblk1 --fstype=ext4 --label var
> --align 4096 --rootfs-dir=${IMAGE_ROOTFS}/var
>
> For an example see scripts/lib/wic/canned-wks/efi-bootdisk.wks.in
Yeah, I looked all  the wks files an nothing jumped out at me.  The
"--rootfs-dir" is not  intuitive for selecting a single dir  but I see
that it does address my issue.

thanks,
Armin
>
> Thanks,
> Paul