[OE-core] [PATCH 1/2] devtool/standard.py: Allow recipe to disable menuconfig logic

[Schrempf Frieder]

On 13.12.19 17:14, Tom Hochstein wrote:
> I made a PR as well:
> 
> https://github.com/openembedded/openembedded-core/pull/57
> 
> Tom

I don't think PRs are accepted for oe-core. Your patches should be ok, 
if someone reviews and applies them.

Dear maintainers, could you consider to review/apply this fix for 
master/zeus? It fixes an annoying issue when working with devtool and 
u-boot.

> 
>> -----Original Message-----
>> From: Schrempf Frieder <frieder.schrempf at kontron.de>
>> Sent: Wednesday, December 4, 2019 10:44 AM
>> To: Tom Hochstein <tom.hochstein at nxp.com>; openembedded-core at lists.openembedded.org
>> Subject: Re: [OE-core] [PATCH 1/2] devtool/standard.py: Allow recipe to disable menuconfig logic
>>
>> Hi,
>>
>> On 20.11.19 20:25, Tom Hochstein wrote:
>>> u-boot.inc supports u-boot recipes with or without menuconfig [1].
>>> However, running devtool on a u-boot recipe that does not support menuconfig
>>> results in an error:
>>>
>>> cp: cannot stat '/home/r60874/upstream/fsl-xwayland/tmp/work/imx8mmevk-fsl-linux/u-boot-imx/2018.03-r0/u-boot-imx-
>> 2018.03//.config': No such file or directory
>>>
>>> The problem is the devtool logic assumes that any recipe with a do_menuconfig task
>>> will generate a .config in do_configure().
>>>
>>> Fix the problem by removing the assumption with a flag that the recipe can control,
>>> like this:
>>>
>>> do_configure() {
>>>       if [ menuconfig-supported ]; then
>>>           ...
>>>       else
>>>           DEVTOOL_DISABLE_MENUCONFIG=true
>>>       fi
>>> }
>>>
>>> [1] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenembedded%2Fopenembedded-
>> core%2Fcommit%2F11278e3b2c75be80645b9841763a97dbb35daadc&amp;data=02%7C01%7Ctom.hochstein%40nxp.com%7C5d668f64
>> d3a044abb11e08d778d92bef%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637110746452407756&amp;sdata=AHjvw91G8N7
>> Wuf%2BORB%2B5E7cxE5cciCpnEktIqkoFKMY%3D&amp;reserved=0
>>>
>>> Signed-off-by: Tom Hochstein <tom.hochstein at nxp.com>
>>
>> I'm experiencing this issue since moving to zeus. Your fix in this
>> series works fine for me and I would really like to see this merged in zeus.
>>
>> Thanks,
>> Frieder
>>
>>> ---
>>>    scripts/lib/devtool/standard.py | 6 ++++--
>>>    1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
>>> index 8d9c1a3022..66bd1415c3 100644
>>> --- a/scripts/lib/devtool/standard.py
>>> +++ b/scripts/lib/devtool/standard.py
>>> @@ -940,8 +940,10 @@ def modify(args, config, basepath, workspace):
>>>                            '}\n')
>>>                if rd.getVarFlag('do_menuconfig','task'):
>>>                    f.write('\ndo_configure_append() {\n'
>>> -                '    cp ${B}/.config ${S}/.config.baseline\n'
>>> -                '    ln -sfT ${B}/.config ${S}/.config.new\n'
>>> +                '    if [ ! ${DEVTOOL_DISABLE_MENUCONFIG} ]; then\n'
>>> +                '        cp ${B}/.config ${S}/.config.baseline\n'
>>> +                '        ln -sfT ${B}/.config ${S}/.config.new\n'
>>> +                '    fi\n'
>>>                    '}\n')
>>>                if initial_rev:
>>>                    f.write('\n# initial_rev: %s\n' % initial_rev)
>>>