[OE-core] [PATCH 06/11] insane.bbclass: introduce a warning for mime missing in inherit

[Peter Kjellerstedt]

> -----Original Message-----
> From: openembedded-core-bounces at lists.openembedded.org <openembedded-core-
> bounces at lists.openembedded.org> On Behalf Of Andreas Müller
> Sent: den 9 januari 2020 21:26
> To: openembedded-core at lists.openembedded.org
> Subject: [OE-core] [PATCH 06/11] insane.bbclass: introduce a warning for
> mime missing in inherit
> 
> * looking through layers it looks that usage of mime.bbclass is somewhat
>   orphaned
> * now that update-mime-database is called once only at image creation time,
>   costs of mime.bbclass are limited
> 
> Signed-off-by: Andreas Müller <schnitzeltony at gmail.com>
> ---
>  meta/classes/insane.bbclass | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index f856cf6a2b..442e9e5113 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -28,6 +28,7 @@ WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi \
>              pn-overrides infodir build-deps src-uri-bad \
>              unknown-configure-option symlink-to-sysroot multilib \
>              invalid-packageconfig host-user-contaminated uppercase-pn patch-fuzz \
> +            mime \
>              "
>  ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \
>              perms dep-cmp pkgvarcheck perm-config perm-line perm-link \
> @@ -185,6 +186,17 @@ def package_qa_check_staticdev(path, name, d, elf, messages):
>          package_qa_add_message(messages, "staticdev", "non -staticdev package contains static .a library: %s path '%s'" % \
>                   (name, package_qa_clean_path(path,d)))
> 
> +QAPATHTEST[mime] = "package_qa_check_mime"
> +def package_qa_check_mime(path, name, d, elf, messages):
> +    """
> +    Check if package installs mime types to to /usr/share/mime/packages

Change "to to" to "to".

> +    while no inheriting mime.bbclass
> +    """
> +
> +    if d.getVar("mimedir") + "/packages" in path and path.endswith('.xml') and not bb.data.inherits_class("mime", d):
> +        package_qa_add_message(messages, "mime", "package contains mime types but does not inhert mime.bbclass: %s path '%s'" % \
> +                 (name, package_qa_clean_path(path,d)))
> +
>  def package_qa_check_libdir(d):
>      """
>      Check for wrong library installation paths. For instance, catch
> --
> 2.21.0

//Peter