[OE-core] [PATCHv5 3/8] kernel-artifact-names.bbclass: use PR instead of PKGR in KERNEL_ARTIFACT_NAME
Richard Purdie
richard.purdie at linuxfoundation.org
Wed Jan 15 10:11:54 UTC 2020
On Tue, 2020-01-14 at 10:12 +0100, Martin Jansa wrote:
> * otherwise PKGR seen in do_install, do_deploy and do_deploy_links
> will
> have different value in each of them (PRSERV will return different
> value of EXTENDPRAUTO because TASKHASH is different for each of
> these
> tasks and also cause unnecessary multiple EXTENDPRAUTO increments
> for
> each build).
>
> [YOCTO #12937]
>
> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> ---
> meta/classes/kernel-artifact-names.bbclass | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel-artifact-names.bbclass
> b/meta/classes/kernel-artifact-names.bbclass
> index 529e0c565e..41ef6e884d 100644
> --- a/meta/classes/kernel-artifact-names.bbclass
> +++ b/meta/classes/kernel-artifact-names.bbclass
> @@ -6,7 +6,12 @@
>
> inherit image-artifact-names
>
> -KERNEL_ARTIFACT_NAME ?= "${PKGE}-${PKGV}-${PKGR}-${MACHINE}"
> +# Intentionally use PR instead of PKGR, because EXTENDPRAUTO
> included
> +# in PKGR will have different value for
> do_install/do_deploy/do_deploy_links
> +# tasks with different TASKHASH, causing multiple EXTENDPRAUTO
> increments for
> +# each kernel build and more importantly preventing do_deploy_links
> to
> +# reference artifacts created do_deploy task
> +KERNEL_ARTIFACT_NAME ?= "${PKGE}-${PKGV}-${PR}-${MACHINE}"
> KERNEL_ARTIFACT_LINK_NAME ?=
> "${KERNEL_ARTIFACT_NAME}${IMAGE_VERSION_SUFFIX}"
Perhaps this is why patch 5/8 is necessary? ("kernel.bbclass: drop
unnecessary package_get_auto_pr for do_install")
I suspect there are links between these two patches...
Cheers,
Richard
More information about the Openembedded-core
mailing list