[OE-core] [PATCH] core: recipes: fix some native tools dependencies

[Sumit Garg]

On Fri, 17 Jan 2020 at 16:21, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
>
> On Fri, 2020-01-17 at 12:29 +0530, Sumit Garg wrote:
> > Some native tools dependency issues were seen while building with
> > external GCC tool-set rather than source GCC tool-set. While building
> > with source tool-set these dependencies were implicitly met which is not
> > the case with external tool-set. So explicitly state these native tools
> > dependencies.
> >
> > Signed-off-by: Sumit Garg <sumit.garg at linaro.org>
> > ---
> >  meta/classes/autotools.bbclass                     | 2 +-
> >  meta/recipes-extended/man-db/man-db_2.9.0.bb       | 2 +-
> >  meta/recipes-graphics/xorg-app/xorg-app-common.inc | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
> > index 3d22ad0..4c71be2 100644
> > --- a/meta/classes/autotools.bbclass
> > +++ b/meta/classes/autotools.bbclass
> > @@ -10,7 +10,7 @@ def autotools_dep_prepend(d):
> >      deps += 'autoconf-native automake-native '
> >
> >      if not pn in ['libtool', 'libtool-native'] and not pn.endswith("libtool-cross"):
> > -        deps += 'libtool-native '
> > +        deps += 'libtool-native xz-native '
> >          if not bb.data.inherits_class('native', d) \
> >                          and not bb.data.inherits_class('nativesdk', d) \
> >                          and not bb.data.inherits_class('cross', d) \
>
> Where does autotools depend on xz? I don't really understand that
> dependency. What kind of failures was this causing?
>

Here is one of the failures I observed:

| /home/sumit.garg/T2502/poky/build/tmp/work/aarch64-poky-linux/psmisc/23.2-r0/recipe-sysroot-native/usr/bin/autopoint:
485: /home/sumit.garg/T2502/poky/build/tmp/work/aarch64-poky-linux/psmisc/23.2-r0/recipe-sysroot-native/usr/bin/autopoint:
xz: not found
| tar: This does not look like a tar archive
| tar: gettext-0.19.3: Not found in archive
| tar: Exiting with failure status due to previous errors
| autopoint: *** infrastructure files for version 0.19.3 not found;
this is autopoint from GNU gettext-tools 0.19.8.1
| autopoint: *** Stop.
| autoreconf: autopoint failed with exit status: 1
| WARNING: exit code 1 from a shell command.

But looking at this failure again it seems like "autopoint" is
provided by gettext rather than autotools. So yes, I think you are
right and "xz-native" dependency should go in
meta/classes/gettext.bbclass instead as follows:

diff --git a/meta/classes/gettext.bbclass b/meta/classes/gettext.bbclass
index be2ef3b311..443c9c4cb0 100644
--- a/meta/classes/gettext.bbclass
+++ b/meta/classes/gettext.bbclass
@@ -2,8 +2,8 @@ def gettext_dependencies(d):
     if d.getVar('INHIBIT_DEFAULT_DEPS') and not oe.utils.inherits(d,
'cross-canadian'):
         return ""
     if d.getVar('USE_NLS') == 'no':
-        return "gettext-minimal-native"
-    return "gettext-native"
+        return "gettext-minimal-native xz-native"
+    return "gettext-native xz-native"

 def gettext_oeconf(d):
     if d.getVar('USE_NLS') == 'no':

-Sumit

> Cheers,
>
> Richard
>