[OE-core] [PATCH] gstreamer1.0-plugins-common.inc: disable orc on mips

[Yu, Mingli]

On 01/22/20 02:36, Khem Raj wrote:
> On Mon, Jan 20, 2020 at 11:19 PM <mingli.yu at windriver.com> wrote:
>>
>> From: Mingli Yu <mingli.yu at windriver.com>
>>
>> After transiton to meson build for gstreamer series,
>> for gstreamer1.0-plugins-base, with below two commits
>> introduced:
>> 238080ed89 gstreamer: Remove unused common files and patches
>> 20614408dc gstreamer1.0-plugins-base: Transition to meson based builds
>>
>> With below config in local.conf
>> MACHINE ??= "qemumips64"
>> require conf/multilib.conf
>> MULTILIB_GLOBAL_VARIANTS_append = " libn32"
>> MULTILIBS ?= "multilib:lib32 multilib:libn32"
>> DEFAULTTUNE_virtclass-multilib-lib32 ?= "mips"
>> DEFAULTTUNE_virtclass-multilib-libn32 ?= "mips64-n32"
>>
>> there comes below failure:
>> $ bitbake lib32-gstreamer1.0-plugins-base
>> [snip]
>> mips-pokymllib32-linux-gcc -meb -mabi=32 -mhard-float -fstack-protector-strong -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/mybuild/tmp/work/mips-pokymllib32-linux/lib32-gstreamer1.0-plugins-base/1.16.1-r0/lib32-recipe-sysroot -Itests/check/7d01337@@orc_video at exe -Itests/check -I../gst-plugins-base-1.16.1/tests/check -I/mybuild/tmp/work/mips-pokymllib32-linux/lib32-gstreamer1.0-plugins-base/1.16.1-r0/lib32-recipe-sysroot/usr/include/orc-0.4 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -fvisibility=hidden -fno-strict-aliasing -DG_DISABLE_CAST_CHECKS -Wmissing-declarations -Wredundant-decls -Wundef -Wwrite-strings -Wformat -Wformat-nonliteral -Wformat-security -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wvla -Wpointer-arith -Wmissing-prototypes -Wdeclaration-after-statement -O2 -g -feliminate-unused-debug-types -fmacro-prefix-map=/mybuild/tmp/work/mips-pokymllib32-linux/lib32-gstreamer1.0-plugins-base/1.16.1-r!
 0=/u
>>   sr/src/debug/lib32-gstreamer1.0-plugins-base/1.16.1-r0 -fdebug-prefix-map=/mybuild/tmp/work/mips-pokymllib32-linux/lib32-gstreamer1.0-plugins-base/1.16.1-r0=/usr/src/debug/lib32-gstreamer1.0-plugins-base/1.16.1-r0 -fdebug-prefix-map=/mybuild/tmp/work/mips-pokymllib32-linux/lib32-gstreamer1.0-plugins-base/1.16.1-r0/lib32-recipe-sysroot= -fdebug-prefix-map=/mybuild/tmp/work/mips-pokymllib32-linux/lib32-gstreamer1.0-plugins-base/1.16.1-r0/recipe-sysroot-native= -MD -MQ 'tests/check/7d01337@@orc_video at exe/meson-generated_.._orc_video.c.o' -MF 'tests/check/7d01337@@orc_video at exe/meson-generated_.._orc_video.c.o.d' -o 'tests/check/7d01337@@orc_video at exe/meson-generated_.._orc_video.c.o' -c tests/check/orc_video.c
>> FAILED: tests/check/7d01337@@orc_video at exe/meson-generated_.._orc_video.c.o
>> {standard input}: Assembler messages:
>> {standard input}:46587: Error: branch out of range
>> {standard input}:46613: Error: branch out of range
>> [snip]
>>
>> BTW, gstreamer1.0-plugins-good also occurs
>> the same build failure as above.
>
> I think there is some difference in behavior that meson migration has
> brought. It will be good to see compiler cmdline for same file on zeus
> e.g. perhaps we missed some flags

Hi Khem,

Thanks your respond!

Yes, it should be some different behavior I guess after migration to 
meson. Have compared basically for the flags before I sent the patch 
actually and didn't find the apparent difference. I prefer disable the 
orc first on mips.

Hi Carlos,

Any suggestion?

>
>>
>> Disable orc as workaround to fix the above issue
>>
>> Signed-off-by: Mingli Yu <mingli.yu at windriver.com>
>> ---
>>   .../findutils/{findutils_4.6.0.bb => findutils_4.7.0.bb}     | 0
>>   .../gstreamer/gstreamer1.0-plugins-common.inc                | 5 ++++-
>>   2 files changed, 4 insertions(+), 1 deletion(-)
>>   rename meta/recipes-extended/findutils/{findutils_4.6.0.bb => findutils_4.7.0.bb} (100%)
>>
>> diff --git a/meta/recipes-extended/findutils/findutils_4.6.0.bb b/meta/recipes-extended/findutils/findutils_4.7.0.bb
>> similarity index 100%
>> rename from meta/recipes-extended/findutils/findutils_4.6.0.bb
>> rename to meta/recipes-extended/findutils/findutils_4.7.0.bb
>> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-common.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-common.inc
>> index ccf55500a9..3896424b2d 100644
>> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-common.inc
>> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-common.inc
>> @@ -18,7 +18,10 @@ require gstreamer1.0-plugins-packaging.inc
>>   # This value is used in the PACKAGECONFIG values for each plugin set recipe.
>>   # By modifying it, Orc can be enabled/disabled in all of these recipes at once.
>>   GSTREAMER_ORC ?= "orc"
>> -
>> +# workaround to disable orc on mips to fix the build failure
>> +# {standard input}: Assembler messages:
>> +# {standard input}:46587: Error: branch out of range
>> +GSTREAMER_ORC_remove_mips = "orc"
>
> No need to remove set it
> GSTREAMER_ORC_mips = ""

Okay, will sent v3 to include the change.

Thanks,

>
>>   PACKAGECONFIG[orc] = "-Dorc=enabled,-Dorc=disabled,orc orc-native"
>>
>>   # TODO: put this in a gettext.bbclass patch (with variables to allow for
>> --
>> 2.23.0
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>