[OE-core] [PATCH 1/3] packagegroup-base: only pull in dosfstools if licensing allows

[Andre McCurdy]

On Wed, Jan 22, 2020 at 6:46 AM Ross Burton <ross.burton at intel.com> wrote:
>
> packagegroup-base-vfat RRECOMMENDS on dosfstools, but this is GPLv3 so
> may be blacklisted.  Respect INCOMPATIBLE_LICENSE and don't recommend if
> GPL-3.0 has been blacklisted.
>
> Signed-off-by: Ross Burton <ross.burton at intel.com>
> ---
>  meta/recipes-core/packagegroups/packagegroup-base.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb b/meta/recipes-core/packagegroups/packagegroup-base.bb
> index 1f802da09b7..3476db09c35 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> @@ -168,7 +168,7 @@ RRECOMMENDS_packagegroup-base-vfat = "\
>      kernel-module-vfat \
>      kernel-module-nls-iso8859-1 \
>      kernel-module-nls-cp437 \
> -    dosfstools"
> +    ${@bb.utils.contains("INCOMPATIBLE_LICENSE", "GPL-3.0", "", "dosfstools", d)}"

Should this be using incompatible_license_contains() instead of
bb.utils.contains()?

>  SUMMARY_packagegroup-base-alsa = "ALSA sound support"
>  RDEPENDS_packagegroup-base-alsa = "\
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core