[OE-core] [PATCH v5 00/13] NPM refactoring

[Richard Purdie]

On Mon, 2020-01-20 at 11:26 +0100, Jean-Marie LEMETAYER wrote:
> Hi folks and happy new year,
> 
> For readability here is a link if you want the history of this patchset:
> http://lists.openembedded.org/pipermail/openembedded-core/2019-December/290298.html

Thanks for this! I think we're nearly there.

There were some selftest failures:

https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/632

The reproducible one isn't from your patches but some are:

2020-01-23 18:32:58,726 - oe-selftest - INFO - RESULTS - devtool.DevtoolAddTests.test_devtool_add_npm: FAILED (16.29s)
2020-01-23 18:32:58,726 - oe-selftest - INFO - RESULTS - devtool.DevtoolUpgradeTests.test_devtool_finish_upgrade_origlayer: FAILED (31.89s)
2020-01-23 18:32:58,726 - oe-selftest - INFO - RESULTS - devtool.DevtoolUpgradeTests.test_devtool_finish_upgrade_otherlayer: FAILED (44.65s)
2020-01-23 18:32:58,726 - oe-selftest - INFO - RESULTS - devtool.DevtoolUpgradeTests.test_devtool_upgrade: FAILED (33.96s)
2020-01-23 18:32:58,726 - oe-selftest - INFO - RESULTS - recipetool.RecipetoolTests.test_recipetool_create: FAILED (8.81s)
2020-01-23 18:32:58,726 - oe-selftest - INFO - RESULTS - recipetool.RecipetoolTests.test_recipetool_create_cmake: FAILED (9.25s)
2020-01-23 18:32:58,726 - oe-selftest - INFO - RESULTS - recipetool.RecipetoolTests.test_recipetool_create_npm: FAILED (3.56s)
2020-01-23 18:32:58,726 - oe-selftest - INFO - RESULTS - recipetool.RecipetoolTests.test_recipetool_create_python3_distutils: FAILED (8.60s)
2020-01-23 18:32:58,727 - oe-selftest - INFO - RESULTS - recipetool.RecipetoolTests.test_recipetool_create_python3_setuptools: FAILED (9.33s)
2020-01-23 18:32:58,727 - oe-selftest - INFO - RESULTS - reproducible.ReproducibleTests.test_reproducible_builds: FAILED (3620.27s)

Mostly things like:

Traceback (most recent call last):
  File "/home/pokybuild/yocto-worker/oe-selftest-centos/build/scripts/devtool", line 334, in <module>
    ret = main()
  File "/home/pokybuild/yocto-worker/oe-selftest-centos/build/scripts/devtool", line 321, in main
    ret = args.func(args, config, basepath, workspace)
  File "/home/pokybuild/yocto-worker/oe-selftest-centos/build/scripts/lib/devtool/upgrade.py", line 557, in upgrade
    tinfoil, rd)
  File "/home/pokybuild/yocto-worker/oe-selftest-centos/build/scripts/lib/devtool/upgrade.py", line 218, in _extract_new_source
    md5 = checksums['md5sum']
KeyError: 'md5sum'

from some of the checksum code changes but also some nodejs-native
being missing (incorrect guards on npm code?)

Could you have a look into those please?

Cheers,

Richard