[OE-core] [OE-Core][PATCH] libxcrypt: Enable static builds

[Richard Purdie]

On Wed, 2020-01-22 at 07:19 +0000, Alex Kiernan wrote:
> Whilst glibc builds static binaries libxcrypt doesn't, without which
> we
> can't build, for example, a static busybox. Enable static libraries
> here
> so that anyone who needs a static binary using just basic libraries
> has
> one fewer dependencies to track down post libxcrypt being split out
> of
> glibc.
> 
> Signed-off-by: Alex Kiernan <alex.kiernan at gmail.com>
> ---
> 
>  meta/recipes-core/libxcrypt/libxcrypt.inc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-core/libxcrypt/libxcrypt.inc
> b/meta/recipes-core/libxcrypt/libxcrypt.inc
> index accbdd636152..e98d8084470c 100644
> --- a/meta/recipes-core/libxcrypt/libxcrypt.inc
> +++ b/meta/recipes-core/libxcrypt/libxcrypt.inc
> @@ -32,4 +32,6 @@ CFLAGS += "-fcommon"
>  API = "--disable-obsolete-api"
>  EXTRA_OECONF += "${API}"
>  
> +DISABLE_STATIC = ""
> +

My worry with this is where the line is drawn. We let glibc generate
its static libs since turning them off turned out to be a nightmare, we
disabled everything else we could, assuming the user would turn on what
they need if they need it.

In some ways I'd much prefer this was in some example config rather
than building things piecemeal that most people don't use?

Cheers,

Richard