[OE-core] [PATCH 1/2] glibc: Explicitly disable msgfmt

Peter Kjellerstedt peter.kjellerstedt at axis.com
Sun Mar 8 02:40:24 UTC 2020


> -----Original Message-----
> From: openembedded-core-bounces at lists.openembedded.org <openembedded-core-
> bounces at lists.openembedded.org> On Behalf Of Richard Purdie
> Sent: den 7 mars 2020 23:38
> To: openembedded-core at lists.openembedded.org
> Subject: [OE-core] [PATCH 1/2] glibc: Explicitly disable msgfmt
> 
> If configure is rerun it finds msgfmt from gettext-native which is installed
> during package_write_ipk|deb and means builds are not determinisic.
> 
> Whether msgfmt is needed is debatable (libc.mo files arne't generated without

arne't -> aren't

> it) however we should at least be consistent which this patch ensures.

Add a period and two commas:

it). However, we should at least be consistent, which this patch ensures.

> 
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> ---
>  meta/recipes-core/glibc/glibc.inc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-core/glibc/glibc.inc b/meta/recipes-
> core/glibc/glibc.inc
> index 58d2ba7bc44..23a6ca99ae0 100644
> --- a/meta/recipes-core/glibc/glibc.inc
> +++ b/meta/recipes-core/glibc/glibc.inc
> @@ -9,8 +9,11 @@ inherit autotools texinfo features_check systemd
> 
>  LEAD_SONAME = "libc.so"
> 
> +# msgfmt could come from gettext-native but we don't depend on that and
> +# disable for reproducibility
>  CACHED_CONFIGUREVARS += " \
>    ac_cv_path_BASH_SHELL=${base_bindir}/bash \
> +  ac_cv_prog_MSGFMT= \
>    libc_cv_slibdir=${base_libdir} \
>    libc_cv_rootsbindir=${base_sbindir} \
>    libc_cv_localedir=${localedir} \
> --
> 2.25.0

//Peter



More information about the Openembedded-core mailing list