<br><br><div class="gmail_quote">2011/7/28 Ben Gardiner <span dir="ltr"><<a href="mailto:bengardiner@nanometrics.ca">bengardiner@nanometrics.ca</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi Koen, Frans,<br>
<div class="im"><br>
On Thu, Jul 28, 2011 at 6:48 AM, Koen Kooi <<a href="mailto:koen@dominion.thruhere.net">koen@dominion.thruhere.net</a>> wrote:<br>
><br>
> Op 28 jul. 2011, om 05:38 heeft Ben Gardiner het volgende geschreven:<br>
><br>
</div><div class="im">>> Signed-off-by: Frans Meulenbroeks <<a href="mailto:fransmeulenbroeks@gmail.com">fransmeulenbroeks@gmail.com</a>><br>
</div><div class="im">>> Signed-off-by: Ben Gardiner <<a href="mailto:bengardiner@nanometrics.ca">bengardiner@nanometrics.ca</a>><br>
>> Signed-off-by: Tom Rini <<a href="mailto:tom_rini@mentor.com">tom_rini@mentor.com</a>><br>
>><br>
>> This recipe is a port of recipes/raptor/<a href="http://raptor_1.4.21.bb" target="_blank">raptor_1.4.21.bb</a> from<br>
>> git://<a href="http://git.openembedded.org/openembedded" target="_blank">git.openembedded.org/openembedded</a>, commits<br>
>> 01e8e9f325d8d251e852e7a5704b5fe50880e1ad 'raptor: added recipe' and<br>
>> f1d24b5a986233f869364eb109476f5184e76d10 'raptor: add libxml2 DEPENDS'<br>
><br>
</div><div class="im">> Why does this need to be in OE-core and not in some other layer? It doesn't look so core to me, especially since nothing in oe-core (or meta-oe/efl/gnome for that matter) depends on it<br>
<br>
</div>Because oe-core's meta/recipes-support (naively) seemed like a<br>
reasonable place for it. I would be happy to re-spin the patch for<br>
locating it in any layer. Please advise me.<br></blockquote><div><br>oe-core is only for core recipes. Not sure about the exact definition, but I suspect it is something like "recipes that (virtually) everybody needs".<br>
I'm not sure about layer policies, but maybe this could go to meta-oe. <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
It's true that nothing depends on it. As Frans mentions later it's<br>
only dependent in oe.dev is flickrcurl. Raptor is both a library and a<br>
utility; we use the latter so raptor itself is a dependency of our<br>
images.<br>
<div class="im"><br>
>><br>
>> The recipe was modified by adding a LIC_FILES_CHKSUM assignment.<br>
>><br>
>> Signed-off-by: Ben Gardiner <<a href="mailto:bengardiner@nanometrics.ca">bengardiner@nanometrics.ca</a>><br>
>><br>
>> ---<br>
>><br>
>> Not tested in the oe-core + meta-openembedded et. al. layers.<br>
<br>
</div>I'm sorry for the confusion -- this recipe is/was tested in oe.dev and<br>
2011.03-maintenance branches.<br></blockquote><div><br>I'd say that before submitting you should as a minimum test that it builds properly in the layer you are submitting it (so e.g. we're sure all depends are there). <br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im"><br>
> So why are you sending it if it isn't tested?<br>
><br>
</div><div class="im">>> We are not<br>
>> ready yet to migrate from the 2011.03-maintenance branch. This patch is<br>
>> proposed for inclusion in oe-core so that we can meet the new policy<br>
>> requirements for inclusion in the 2011.03-maintenance branch<br>
><br>
</div><div class="im">> Where does it say it's OK to do a pull request for untested recipes? And where does it say it needs to be in OE-core first?<br>
<br>
</div>My understanding of Tom's post to the oe.dev mailing list is that<br>
commits in pull-requests for 2011.03 need to first be oe-core or one<br>
of its layers.<br></blockquote><div><br>No idea here. <br>But why would add a patch for LIC_FILES_CHECKSUM in the maintenance tree.<br>If I recall correctly those are not needed in 2011.03 (but if it is and it is missing from the recipe, I think it should be added, if not, probably leave the recipe as is).<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
In Message-ID: <<a href="mailto:4DFA7108.5020103@mentor.com">4DFA7108.5020103@mentor.com</a>> On Thu, Jun 16, 2011 at<br>
5:09 PM, Tom Rini <<a href="mailto:tom_rini@mentor.com">tom_rini@mentor.com</a>> wrote:<br>
> -----BEGIN PGP SIGNED MESSAGE-----<br>
> Hash: SHA1<br>
><br>
> Hi all,<br>
><br>
> As part of this weeks TSC meeting, an agenda item was brought up about<br>
> the 2011.03-maintenance branch and oe-core / etc. I have now updated<br>
> the policy about where changes need to be before they can be included in<br>
> 2011.03-maintenance to include being in oe-core / meta-oe or other<br>
> relevant public layer instead of being only in the oe.dev master branch.<br>
> This is not a policy change, but a clarification of what was there<br>
> previously. Thanks all!<br>
<div class="im">><br>
<br>
On Thu, Jul 28, 2011 at 7:29 AM, Frans Meulenbroeks<br>
<<a href="mailto:fransmeulenbroeks@gmail.com">fransmeulenbroeks@gmail.com</a>> wrote:<br>
><br>
><br>
> 2011/7/28 Ben Gardiner <<a href="mailto:bengardiner@nanometrics.ca">bengardiner@nanometrics.ca</a>><br>
>><br>
>> Signed-off-by: Frans Meulenbroeks <<a href="mailto:fransmeulenbroeks@gmail.com">fransmeulenbroeks@gmail.com</a>><br>
><br>
> Eh, yes and no.<br>
><br>
> I did write the original recipe and commited it on 14 aug 2010 with a<br>
> sign-off message.<br>
> As such this got my signoff, but I am not sure the signoff should be<br>
> repeated if this moved to oe-core.<br>
<br>
</div>Fair enough. It is your Sign-off to give or take.<br>
<br>
I was following the patch message guidelines. "Example: Importaing<br>
from Elsewhere Modified" in particular:<br>
<br>
<a href="http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines#Example:_Importing_from_Elsewhere_Modified" target="_blank">http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines#Example:_Importing_from_Elsewhere_Modified</a><br>
</blockquote><div><br>Ah ok, Those guidelines are fairly new and I was not too aware of them. If it is in accordance with the guidelines it is fine with me to keep them.<br>I was mainly triggered by the signed-off lines at the beginning of your message (which I don't think are in accordance to the above mentioned guidelines). <br>
The only concern I have is that the sign-off would be interpreted as my blessing for this patch in oe-core. If it only is used as an indicator of the origin or as a statement that I released and was entitled to release the original stuff, that is ok (as that is still appropriate).<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
I will remove your Sign-off in v2.<br>
<div class="im"><br>
> My sign-off at that time is definitely not to be used as a suggestion it is<br>
> ok for oe-core (actually I feel this is not something for oe-core)<br>
<br>
</div>Understood -- I am happy to re-spin for inclusion in any layer. Please advise.<br>
<br>
Best Regards,<br>
Ben Gardiner<br>
<br>
---<br>
Nanometrics Inc.<br>
<a href="http://www.nanometrics.ca" target="_blank">http://www.nanometrics.ca</a><br>
</blockquote></div><br>