<br><br><div class="gmail_quote">2011/7/28 Ben Gardiner <span dir="ltr"><<a href="mailto:bengardiner@nanometrics.ca">bengardiner@nanometrics.ca</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div><div class="h5">
<br>
</div></div><br>Well, I would not submit _this_ patch for pull-request. I was hoping<br>
to get this version of raptor included and then submit a pull-request<br>
for a cherry-pick of the patch to add libxml2 to DEPENDS.<br></blockquote><div><br>Ah, missed that you also added libxml2. <br>Not sure about the policies of the maintenance branch, but I suspect the proper way would be to fix and test in openembedded then submit a pull request.<br>
Then again maybe the policies for the maintenance branch are different.<br><br>[...]<br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><div class="h5">
>> <a href="http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines#Example:_Importing_from_Elsewhere_Modified" target="_blank">http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines#Example:_Importing_from_Elsewhere_Modified</a><br>
><br>
> Ah ok, Those guidelines are fairly new and I was not too aware of them. If<br>
> it is in accordance with the guidelines it is fine with me to keep them.<br>
> I was mainly triggered by the signed-off lines at the beginning of your<br>
> message (which I don't think are in accordance to the above mentioned<br>
> guidelines).<br>
<br>
</div></div><br>Oh. I thought they were [in accordance]. I guess there would usually<br>
be a commit body before the initial Signed-off-by:'s ; however, there<br>
was no original commit body to preserve.<br></blockquote><div><br>Ah ok, understood.<br>Actually, I guess we should preserve the first line of the commit too.<br>This is what git log says:<br><br>frans@frans-desktop:~/workspace/openembedded/recipes/raptor$ git log *<br>
commit 01e8e9f325d8d251e852e7a5704b5fe50880e1ad<br>Author: Frans Meulenbroeks <<a href="mailto:fransmeulenbroeks@gmail.com">fransmeulenbroeks@gmail.com</a>><br>Date: Sat Aug 14 21:27:49 2010 +0200<br><br> raptor: added recipe<br>
<br> Signed-off-by: Frans Meulenbroeks <<a href="mailto:fransmeulenbroeks@gmail.com">fransmeulenbroeks@gmail.com</a>><br> <br></div><br></div><br>Best regards, Frans.<br>