<div class="gmail_quote">On Fri, Dec 9, 2011 at 12:18, Richard Purdie <span dir="ltr"><<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>This patch appears to:</div>
<br>
a) Remove multilib support from the recipe<br></blockquote><div><br></div><div>Fixed.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
b) Drop the git version of the recipe (no mention of this above?)<br></blockquote><div><br></div><div>I moved it to another commit.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
c) Add a pointless rdepends = d.getVar( "RDEPENDS_%s" % package)<br></blockquote><div><br></div><div>Fixed.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
d) Remove the dnsproxy, dhclient and test options<br></blockquote><div><br></div><div>Fixed.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
e) Add the tools, fake and ntpd options<br></blockquote><div><br></div><div>Fixed.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
f) Reorder variables in the file so as to make the diff unreadable and<br>
hard to review<br></blockquote><div><br></div><div>This was indeed done and I am sorry but it does seems more easy to follow now.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
g) Change the contents of the ${PN}-scripts package<br></blockquote><div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
h) Add tools and tests packages<br></blockquote><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
i) Add a dependeny on ntp<br></blockquote><div><br></div><div>Fixed.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
j) Uses bitbake master funtionality (d.expand()) which will break on<br>
older versions of bitbake (we need to increase the bitbake minimum<br>
version)<br></blockquote><div><br></div><div>Fixed adding a commit that bumps it.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
k) Drops the python scripts dependency<br></blockquote><div><br></div><div>Fixed.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
So all things considered, this kind of change is a nightmare to review<br>
in this form and the commit message only covers half the changes it<br>
makes. We need to do better than this...</blockquote><div><br></div><div>Not easy to accomplish as the difference between meta-oe and oe-core on this was huge. It could have been done better, sure ... and a v2 patch will come shortly.</div>
<div> </div></div>-- <br>Otavio Salvador O.S. Systems<br>E-mail: <a href="mailto:otavio@ossystems.com.br" target="_blank">otavio@ossystems.com.br</a> <a href="http://www.ossystems.com.br" target="_blank">http://www.ossystems.com.br</a><br>
Mobile: <a href="tel:%2B55%2053%209981-7854" value="+555399817854" target="_blank">+55 53 9981-7854</a> <a href="http://projetos.ossystems.com.br" target="_blank">http://projetos.ossystems.com.br</a><br><br>