<div><span style="color: rgb(160, 160, 168); ">On Thursday, December 29, 2011 at 8:50 PM, Lianhao Lu wrote:</span></div>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;">
<span><span style="border-collapse: separate; color: rgb(0, 0, 0); font-family: 'Lucida Grande'; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: 13px; "><span style="font-family: Helvetica; font-size: 13px; "><div>diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass</div><div>index 9040eb4..07d6f9a 100644</div><div>--- a/meta/classes/package.bbclass</div><div>+++ b/meta/classes/package.bbclass</div><div>@@ -351,10 +351,19 @@ def runtime_mapping_rename (varname, d):</div><div></div><div>python package_get_auto_pr() {</div><div>if d.getVar('USE_PR_SERV', True) != "0":</div><div>- auto_pr=prserv_get_pr_auto(d)</div><div>- if auto_pr is None:</div><div>- bb.fatal("Can NOT get auto PR revision from remote PR service")</div><div>+ try:</div><div>+ auto_pr=prserv_get_pr_auto(d)</div><div>+ except Exception as e:</div><div>+ bb.error(str(e))</div><div>+ raise bb.build.FuncFailed(e)</div></span></span></span>
</blockquote>
<div>
<br>
</div><div>Don't do this. I realize there are flawed examples of this elsewhere in the metadata, but this isn't what FuncFailed is intended for. It's what the bitbake exec_func raises when a function fails, not what a function it executes should be raising.</div><div>-- </div><div><div><div>Christopher Larson</div></div></div>