<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
On 2012年02月06日 15:37, Xiaofeng Yan wrote:
<blockquote cite="mid:4F2F8344.5000509@windriver.com" type="cite">On
2012年02月06日 15:05, Martin Jansa wrote:
<br>
<blockquote type="cite">On Mon, Feb 06, 2012 at 02:41:09PM +0800,
Xiaofeng Yan wrote:
<br>
<blockquote type="cite">From: Xiaofeng
Yan<a class="moz-txt-link-rfc2396E" href="mailto:xiaofeng.yan@windriver.com"><xiaofeng.yan@windriver.com></a>
<br>
<br>
The function "g_qsort_with_data" has two kinds of realization.
One calls qsort_r
<br>
from libglib, the other realize itself. the realization method
is controlled by macro "HAVE_QSORT_R".
<br>
qsort_r from libglib cause sort error. Add
no-check-qsort_r.patch for fixing this problem.
<br>
This patch is to fix bug 1959. After this patch is merged into
OE-core I will open a new bug to
<br>
track the reason why qsort_r report normally. For finishing
lsb test in YOCTO 1.2 M3 this patch
<br>
is applied temporarily.
<br>
<br>
Pull URL: git://git.pokylinux.org/poky-contrib.git
<br>
Branch: xiaofeng/1959
<br>
Browse:
<a class="moz-txt-link-freetext" href="http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/1959">http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/1959</a>
<br>
<br>
Thanks,
<br>
Xiaofeng Yan<a class="moz-txt-link-rfc2396E" href="mailto:xiaofeng.yan@windriver.com"><xiaofeng.yan@windriver.com></a>
<br>
---
<br>
</blockquote>
no-check-qsort_r.patch is the same as
remove.test.for.qsort_r.patch from
<br>
<a class="moz-txt-link-freetext" href="http://git.openembedded.org/openembedded-core/commit/?id=74f43e3b269c01dba7cd5215a8e825229bd5ecff">http://git.openembedded.org/openembedded-core/commit/?id=74f43e3b269c01dba7cd5215a8e825229bd5ecff</a>
<br>
<br>
which was later removed from glib-2.0-native in
<br>
<a class="moz-txt-link-freetext" href="http://git.openembedded.org/openembedded-core/commit/?id=37579d7d74d127c90c1e078d05c5bf4ba0b3f755">http://git.openembedded.org/openembedded-core/commit/?id=37579d7d74d127c90c1e078d05c5bf4ba0b3f755</a>
<br>
<br>
and later removed completely in
<br>
<a class="moz-txt-link-freetext" href="http://git.openembedded.org/openembedded-core/commit/?id=812342e44e9e361a0fa93cfcfe65cf4dd6f2fb57">http://git.openembedded.org/openembedded-core/commit/?id=812342e44e9e361a0fa93cfcfe65cf4dd6f2fb57</a>
<br>
<br>
Are you sure this patch is right fix? And no need to split
adding patch
<br>
itself and adding it to SRC_URI to 2 patches.
<br>
<br>
Cheers,
<br>
<br>
</blockquote>
Hi Martin Jansa,
<br>
I reviewed the above link, no-check-qsort_r.patch is the same as
remove.test.for.qsort_r.patch really. Please check attachment for
the test program from LSB 4.1. I think we need this patch because
it is an error really. LSB report the next information:
<br>
<br>
After sorting array, the 0-th element of array should be 1, but is
2
<br>
After sorting array, the 1-th element of array should be 2, but is
1
<br>
After sorting array, the 2-th element of array should be 3, but is
5
<br>
After sorting array, the 4-th element of array should be 5, but is
3
<br>
<br>
<br>
I can reuse this patch which was removed before if you think this
is a bug. Do you any suggestion?
<br>
<br>
Compile this test program.
<br>
$ gcc -g `pkg-config --cflags glib-2.0` gobject_value_arrays.c -o
gobject -lgobject-2.0
<br>
<br>
<br>
</blockquote>
I reviewed the origin patch from Martin Jansa and found that my
patch is different from him. My patch is to remove the check of
qsort_r and the origin had still this check. I also update my patch
because <br>
it have two <a class="moz-txt-link-freetext" href="file://">file://</a> in SRC_URI.<br>
Thank Martin Jansa.<br>
<br>
<blockquote cite="mid:4F2F8344.5000509@windriver.com" type="cite">
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Openembedded-core mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.openembedded.org</a>
<a class="moz-txt-link-freetext" href="http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core">http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core</a>
</pre>
</blockquote>
<br>
</body>
</html>