<p>hi saul:<br>
it seems that my inline comments got lost.<br>
ok, since the origial patch is took from gentoo upstream. so, i thought better to keep what it was, instead of trying to modify. but if you insist, i could cook another patch, put mike(floppym) as author-of?<br>
besides, as mike already point out, the openjade upstream is dead, and i still got no response from them, chance that patch will got accept is rare. what's the upstream-status do you suggest?</p>
<div class="gmail_quote">在 2012-7-3 上午7:46，"Saul Wold" <<a href="mailto:sgw@linux.intel.com">sgw@linux.intel.com</a>>写道：<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 07/02/2012 03:24 PM, Dennis.Yxun wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
hi saul:<br>
please see my comment as following<br>
<br>
</blockquote>
I do not understand what you are getting at here?<br>
<br>
You PATCH file openjade-1.3.2/msggen.pl.patch is what is missing the Upsteam-Status: and SOB (Signed-off-by), the commit message what you have for SOB is Ok, the commit message itself should not have the Upstream-Status: tag, it belongs in the .patch file header.<br>
<br>
Sau!<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
dennis<br>
<br>
At 2012-6-29 AM1:27，"Saul Wold" &<br>
<br>
On 06/27/2012 09:56 PM, dennis lan wrote:<br>
<br>
From: Dennis Lan<<a href="mailto:dennis.yxun@gmail.com" target="_blank">dennis.yxun@gmail.com</a><br>
<mailto:<a href="mailto:dennis.yxun@gmail.com" target="_blank">dennis.yxun@gmail.com</a>><u></u>><br>
<br>
Using Gentoo Linux as the build host, it fails without this patch<br>
Use Getopt::Std in place of <a href="http://getopts.pl" target="_blank">getopts.pl</a> <<a href="http://getopts.pl" target="_blank">http://getopts.pl</a>>.<br>
<br>
<a href="https://bugs.gentoo.org/show___bug.cgi?id=420083" target="_blank">https://bugs.gentoo.org/show__<u></u>_bug.cgi?id=420083</a><br>
<<a href="https://bugs.gentoo.org/show_bug.cgi?id=420083" target="_blank">https://bugs.gentoo.org/show_<u></u>bug.cgi?id=420083</a>><br>
<br>
which following error:<br>
/usr/bin/perl -w ./../<a href="http://msggen.pl" target="_blank">msggen.pl</a> <<a href="http://msggen.pl" target="_blank">http://msggen.pl</a>> -l<br>
jstyleModule InterpreterMessages.msg<br>
/usr/bin/perl -w ./../<a href="http://msggen.pl" target="_blank">msggen.pl</a> <<a href="http://msggen.pl" target="_blank">http://msggen.pl</a>> -l<br>
jstyleModule DssslAppMessages.msg<br>
Undefined subroutine&main::Getopts called at ./../<a href="http://msggen.pl" target="_blank">msggen.pl</a><br>
<<a href="http://msggen.pl" target="_blank">http://msggen.pl</a>> line 22.<br>
make[2]: *** [InterpreterMessages.h] Error 2<br>
make[2]: *** Waiting for unfinished jobs....<br>
Undefined subroutine&main::Getopts called at ./../<a href="http://msggen.pl" target="_blank">msggen.pl</a><br>
<<a href="http://msggen.pl" target="_blank">http://msggen.pl</a>> line 22.<br>
make[2]: *** [DssslAppMessages.h] Error 2<br>
<br>
Upstream-Status: Submitted<br>
[openjade-devel@lists.__<a href="http://sourceforge.net" target="_blank">source<u></u>forge.net</a><br>
<mailto:<a href="mailto:openjade-devel@lists.sourceforge.net" target="_blank">openjade-devel@lists.<u></u>sourceforge.net</a>>]<br>
<br>
This needs to be in the patch file itself, we can track the patches<br>
better that way.<br>
<br>
Signed-off-by: Dennis Lan<<a href="mailto:dennis.yxun@gmail.com" target="_blank">dennis.yxun@gmail.com</a><br>
<mailto:<a href="mailto:dennis.yxun@gmail.com" target="_blank">dennis.yxun@gmail.com</a>><u></u>><br>
---<br>
.../openjade/openjade-1.3.2/__<u></u>msggen.pl.patch | 32<br>
++++++++++++++++++++<br>
.../openjade/<a href="http://openjade-native___1.3.2.bb" target="_blank">openjade-native__<u></u>_1.3.2.bb</a><br>
<<a href="http://openjade-native_1.3.2.bb" target="_blank">http://openjade-native_1.3.2.<u></u>bb</a>> | 1 +<br>
2 files changed, 33 insertions(+), 0 deletions(-)<br>
create mode 100644<br>
meta/recipes-devtools/__<u></u>openjade/openjade-1.3.2/__<u></u>msggen.pl.patch<br>
<br>
diff --git<br>
a/meta/recipes-devtools/__<u></u>openjade/openjade-1.3.2/__<u></u>msggen.pl.patch<br>
b/meta/recipes-devtools/__<u></u>openjade/openjade-1.3.2/__<u></u>msggen.pl.patch<br>
new file mode 100644<br>
index 0000000..1afe68b<br>
--- /dev/null<br>
+++<br>
b/meta/recipes-devtools/__<u></u>openjade/openjade-1.3.2/__<u></u>msggen.pl.patch<br>
<br>
<br>
Please add comment Upstream-Status and SOB to the patch itself.<br>
<br>
Thanks<br>
Sau!<br>
<br>
@@ -0,0 +1,32 @@<br>
+Use Getopt::Std in place of <a href="http://getopts.pl" target="_blank">getopts.pl</a> <<a href="http://getopts.pl" target="_blank">http://getopts.pl</a>>.<br>
+<a href="https://bugs.gentoo.org/show___bug.cgi?id=420083" target="_blank">https://bugs.gentoo.org/show_<u></u>__bug.cgi?id=420083</a><br>
<<a href="https://bugs.gentoo.org/show_bug.cgi?id=420083" target="_blank">https://bugs.gentoo.org/show_<u></u>bug.cgi?id=420083</a>><br>
+<br>
+--- a/<a href="http://msggen.pl" target="_blank">msggen.pl</a> <<a href="http://msggen.pl" target="_blank">http://msggen.pl</a>><br>
++++ b/<a href="http://msggen.pl" target="_blank">msggen.pl</a> <<a href="http://msggen.pl" target="_blank">http://msggen.pl</a>><br>
+@@ -4,6 +4,7 @@<br>
+ # See the file COPYING for copying permission.<br>
+<br>
+ use POSIX;<br>
++use Getopt::Std;<br>
+<br>
+ # Package and version.<br>
+ $package = 'openjade';<br>
+@@ -18,8 +19,7 @@<br>
+ undef $opt_l;<br>
+ undef $opt_p;<br>
+ undef $opt_t;<br>
+-do '<a href="http://getopts.pl" target="_blank">getopts.pl</a> <<a href="http://getopts.pl" target="_blank">http://getopts.pl</a>>';<br>
+-&Getopts('l:p:t:');<br>
++getopts('l:p:t:');<br>
+ $module = $opt_l;<br>
+ $pot_file = $opt_p;<br>
+<br>
+@@ -72,7 +72,7 @@<br>
+ else {<br>
+ $field[0] =~ /^[IWQXE][0-9]$/ ||&error("invalid first<br>
field");;<br>
+ $type[$num] = substr($field[0], 0, 1);<br>
+- $argc = int(substr($field[0], 1, 1));<br>
++ $argc = substr($field[0], 1, 1);<br>
+ }<br>
+ $nargs[$num] = $argc;<br>
+ $field[1] =~ /^[a-zA-Z_][a-zA-Z0-9_]+$/ ||&error("invalid<br>
tag");<br>
diff --git<br>
a/meta/recipes-devtools/__<u></u>openjade/openjade-native_1.3._<u></u>_<a href="http://2.bb" target="_blank">2.bb</a><br>
<<a href="http://openjade-native_1.3.2.bb" target="_blank">http://openjade-native_1.3.2.<u></u>bb</a>><br>
b/meta/recipes-devtools/__<u></u>openjade/openjade-native_1.3._<u></u>_<a href="http://2.bb" target="_blank">2.bb</a><br>
<<a href="http://openjade-native_1.3.2.bb" target="_blank">http://openjade-native_1.3.2.<u></u>bb</a>><br>
index 5b29c1f..efd1e11 100644<br>
---<br>
a/meta/recipes-devtools/__<u></u>openjade/openjade-native_1.3._<u></u>_<a href="http://2.bb" target="_blank">2.bb</a><br>
<<a href="http://openjade-native_1.3.2.bb" target="_blank">http://openjade-native_1.3.2.<u></u>bb</a>><br>
+++<br>
b/meta/recipes-devtools/__<u></u>openjade/openjade-native_1.3._<u></u>_<a href="http://2.bb" target="_blank">2.bb</a><br>
<<a href="http://openjade-native_1.3.2.bb" target="_blank">http://openjade-native_1.3.2.<u></u>bb</a>><br>
@@ -14,6 +14,7 @@ RDEPENDS_${PN} = "sgml-common-native"<br>
<br>
SRC_URI =<br>
"${SOURCEFORGE_MIRROR}/__<u></u>openjade/openjade-${PV}.tar.gz \<br>
file://makefile.patch \<br>
+ file://msggen.pl.patch \<br>
file://reautoconf.patch \<br>
file://user-declared-default-_<u></u>_constructor.patch"<br>
<br>
</blockquote>
</blockquote></div>