<div style="text-align:center"><div align="left">On Mon, Jul 9, 2012 at 8:40 PM, Khem Raj <span dir="ltr"><<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>></span> wrote:</div></div><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Mon, Jul 9, 2012 at 10:00 AM, Richard Purdie<br>
<<a href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@linuxfoundation.org</a>> wrote:<br>
> On Mon, 2012-07-09 at 12:27 +0300, Andrei Gherzan wrote:<br>
>> On Sat, Jul 7, 2012 at 1:54 PM, Robert P. J. Day<br>
>> <<a href="mailto:rpjday@crashcourse.ca">rpjday@crashcourse.ca</a>> wrote:<br>
>><br>
>> "proto=git" is not a valid parameter for the git fetcher.<br>
>><br>
>> NOTE: package matchbox-wm-2-0.1+git1<br>
>> +01fa5465743c9ee43d040350f4405d35293e4869-r1: task do_fetch:<br>
>> Succeeded<br>
>><br>
>> Anyway, in the git.py, code is searching for "protocol" parameter:<br>
>> ud.proto = ud.parm['protocol']<br>
>><br>
>> ... so your change seems legit.<br>
>><br>
>> On another hand, svn.py is using:<br>
>> proto = ud.parm.get('proto', 'svn')<br>
>><br>
>> A good think would be to use the same parameter names for all<br>
>> protocols.<br>
>><br>
> I agree but how do we do this without breaking the world? We probably<br>
> should try and standardise it, probably to "protocol".<br>
<br>
</div>so may be change the keyword to protocol and have both for this<br>
release additionally give a deprecation warning on proto and then<br>
after 1.3 remove proto<br>
<div class="HOEnZb"><div class="h5"></div></div></blockquote></div><br><div>Healthy approach. I can submit patches on this topic if nobody did it already locally. </div><div><br></div><div>@g</div>