<div id="reply-content">
Incredibly sorry for top-posting, but a build history diff should show any delta and assuming none will give a lot more confidence in the changes being complete<span class="Apple-style-span" style="-webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); ">. In theory a simple change of indentation shouldn't result in any changes to the image, right?</span></div><div id="reply-content"><br></div><div id="reply-content">Ross</div><div id="2EF3DB6532B14FB2BE5F53F95F763C24">-- <br>Ross Burton<br><div>Sent with <a href="http://www.sparrowmailapp.com/?sig">Sparrow</a></div><div><br></div></div>
<p style="color: #A0A0A8;">On Wednesday, 11 July 2012 at 18:36, Richard Purdie wrote:</p>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;">
<div id="quoted-message-content"><div><div>On Wed, 2012-07-11 at 11:33 -0500, Peter Seebach wrote:</div><blockquote type="cite"><div><div>On Wed, 11 Jul 2012 17:12:29 +0100</div><div>Richard Purdie <richard.purdie@linuxfoundation.org> wrote:</div><div><br></div><blockquote type="cite"><div><div>I think I at least would find this slightly less confusing as:</div><div><br></div><div>workparentdir = d.getVar("DEBUGSRC_OVERRIDE_PATH", True) or</div><div>os.path.dirname(workdir)</div></div></blockquote><div><br></div><div>Wait, LESS confusing?</div><div><br></div><div>I appear to have tragically misunderstood the design goals of</div><div>package.bbclass. :P</div></div></blockquote><div><br></div><div>Well, we are trying over time... :)</div><div><br></div><blockquote type="cite"><div><div>But yes, that's a good improvement. Applied locally.</div><div><br></div><div>Speaking of confusing: If purely hypothetically I wanted to</div><div>submit a patch which standardized the indentation in package.bbclass,</div><div>would anyone be interested in that? I ask only because while I can</div><div>accept either 8-space or 4-space indentation, I find it comforting when</div><div>any given file full of Python source uses one or the other.</div></div></blockquote><div><br></div><div>It should all use 4 space for python functions. There is however a twist</div><div>which is due to the way we handle _prepend and _append. Those prepends</div><div>and appends have whitespace too and I seem to remember issues with</div><div>whitespace matching.</div><div><br></div><div>Yes, this is horrible. This is why that file hasn't been touched for</div><div>whitespace though.</div><div><br></div><blockquote type="cite"><div><div>And while there's currently only a couple of blocks of 4-space</div><div>indentation in the file, we *normally* use 4-space, that's the</div><div>quasi-official Python community norm, and a LOT of the "too long" lines</div><div>in that file would be much more readable at 4 spaces.</div><div><br></div><div>(This would be a totally separate patch, and I'm not super happy about</div><div>the idea of a patch which updates half or more of the lines in the</div><div>file, but it's not as though it'll be less painful to fix later.)</div></div></blockquote><div><br></div><div>I'd be interested to see how much breakage we get from changing it. In</div><div>fact I just tried it, the result:</div><div><br></div><div>http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rpurdie/t14&id=3db917bfb2455715a3a3a542ea831d05ca1cf9f7</div><div><br></div><div>the particularly nasty bit:</div><div><br></div><div>python populate_packages () {</div><div> # Whitespace is deliberately a tab here due to the number of packages which</div><div> # prepend this fuction :(</div><div> populate_packages_core(d)</div><div>}</div><div><br></div><div>other than that it does seem to be working as long as I tweaked the</div><div>busybox recipe and update-alternatives too. We could go through and</div><div>change all the populate_packages_prepend functions but its the ones</div><div>outside OE-Core I worry about. I also worry there are some _append</div><div>functions now silently failing though :(.</div><div><br></div><div>Cheers,</div><div><br></div><div>Richard</div><div><br></div><div><br></div><div>_______________________________________________</div><div>Openembedded-core mailing list</div><div>Openembedded-core@lists.openembedded.org</div><div>http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core</div></div></div>
</blockquote>
<div>
<br>
</div>