<p>That patch was included in 1.4 version.</p>
<div class="gmail_quote">On Aug 17, 2012 7:20 PM, "Saul Wold" <<a href="mailto:sgw@linux.intel.com">sgw@linux.intel.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 08/16/2012 05:55 AM, Constantin Musca wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Signed-off-by: Constantin Musca <<a href="mailto:constantinx.musca@intel.com" target="_blank">constantinx.musca@intel.com</a>><br>
---<br>
...ck-that-the-string-isn-t-<u></u>empty-before-spl.patch | 37 --------------------<br>
</blockquote>
Why was the patch removed, need to have that in the commit message also.<br>
<br>
Sau!<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
.../connman/{<a href="http://connman_1.3.bb" target="_blank">connman_1.3.bb</a> => <a href="http://connman_1.4.bb" target="_blank">connman_1.4.bb</a>} | 9 +++--<br>
2 files changed, 4 insertions(+), 42 deletions(-)<br>
delete mode 100644 meta/recipes-connectivity/<u></u>connman/connman/0001-storage-<u></u>check-that-the-string-isn-t-<u></u>empty-before-spl.patch<br>
rename meta/recipes-connectivity/<u></u>connman/{<a href="http://connman_1.3.bb" target="_blank">connman_1.3.bb</a> => <a href="http://connman_1.4.bb" target="_blank">connman_1.4.bb</a>} (69%)<br>
<br>
diff --git a/meta/recipes-connectivity/<u></u>connman/connman/0001-storage-<u></u>check-that-the-string-isn-t-<u></u>empty-before-spl.patch b/meta/recipes-connectivity/<u></u>connman/connman/0001-storage-<u></u>check-that-the-string-isn-t-<u></u>empty-before-spl.patch<br>
deleted file mode 100644<br>
index c92b586..0000000<br>
--- a/meta/recipes-connectivity/<u></u>connman/connman/0001-storage-<u></u>check-that-the-string-isn-t-<u></u>empty-before-spl.patch<br>
+++ /dev/null<br>
@@ -1,37 +0,0 @@<br>
-From ea8c7b3efce4c1762411e073893e94<u></u>8de5d552d6 Mon Sep 17 00:00:00 2001<br>
-From: Ross Burton <<a href="mailto:ross.burton@intel.com" target="_blank">ross.burton@intel.com</a>><br>
-Date: Tue, 17 Jul 2012 16:04:12 +0100<br>
-Subject: [PATCH] storage: check that the string isn't empty before splitting<br>
-<br>
-If the string was non-NULL but empty (str="\0"), the following \0 assignment<br>
-would write to str[-1] and thus cause memory corruption.<br>
-<br>
-On PPC and MIPS, this was causing crashes in glibc.<br>
-<br>
-Signed-off-by: Ross Burton <<a href="mailto:ross.burton@intel.com" target="_blank">ross.burton@intel.com</a>><br>
-Upstream-Status: Submitted<br>
-<br>
----<br>
- src/storage.c | 6 +++++-<br>
- 1 file changed, 5 insertions(+), 1 deletion(-)<br>
-<br>
-diff --git a/src/storage.c b/src/storage.c<br>
-index 47bd0cb..20766a3 100644<br>
---- a/src/storage.c<br>
-+++ b/src/storage.c<br>
-@@ -212,7 +212,11 @@ gchar **connman_storage_get_<u></u>services()<br>
- closedir(dir);<br>
-<br>
- str = g_string_free(result, FALSE);<br>
-- if (str) {<br>
-+ if (str && str[0] != '\0') {<br>
-+ /*<br>
-+ * Remove the trailing separator so that services doesn't end up<br>
-+ * with an empty element.<br>
-+ */<br>
- str[strlen(str) - 1] = '\0';<br>
- services = g_strsplit(str, "/", -1);<br>
- }<br>
---<br>
-1.7.10.4<br>
-<br>
diff --git a/meta/recipes-connectivity/<u></u>connman/<a href="http://connman_1.3.bb" target="_blank">connman_1.3.bb</a> b/meta/recipes-connectivity/<u></u>connman/<a href="http://connman_1.4.bb" target="_blank">connman_1.4.bb</a><br>
similarity index 69%<br>
rename from meta/recipes-connectivity/<u></u>connman/<a href="http://connman_1.3.bb" target="_blank">connman_1.3.bb</a><br>
rename to meta/recipes-connectivity/<u></u>connman/<a href="http://connman_1.4.bb" target="_blank">connman_1.4.bb</a><br>
index 4d82794..bd8ba65 100644<br>
--- a/meta/recipes-connectivity/<u></u>connman/<a href="http://connman_1.3.bb" target="_blank">connman_1.3.bb</a><br>
+++ b/meta/recipes-connectivity/<u></u>connman/<a href="http://connman_1.4.bb" target="_blank">connman_1.4.bb</a><br>
@@ -1,13 +1,12 @@<br>
require connman.inc<br>
<br>
-# 1.3 tag<br>
-SRCREV = "<u></u>3c0fa84091524c7cd6237744f2088f<u></u>fee2f1d5ad"<br>
+# 1.4 tag<br>
+SRCREV = "<u></u>f701bbca259f1f35e68d338f31f537<u></u>3f75f3da5f"<br>
SRC_URI = "git://<a href="http://git.kernel.org/pub/scm/network/connman/connman.git" target="_blank">git.kernel.org/pub/scm/<u></u>network/connman/connman.git</a> \<br>
file://0001-plugin.h-Change-<u></u>visibility-to-default-for-<u></u>debug-symb.patch \<br>
file://add_xuser_dbus_<u></u>permission.patch \<br>
file://connman \<br>
file://0002-storage.c-If-<u></u>there-is-no-d_type-support-<u></u>use-fstatat.patch \<br>
- file://0001-timezone.c-If-<u></u>there-is-no-d_type-support-<u></u>use-fstatat.patch \<br>
- file://0001-storage-check-<u></u>that-the-string-isn-t-empty-<u></u>before-spl.patch"<br>
+ file://0001-timezone.c-If-<u></u>there-is-no-d_type-support-<u></u>use-fstatat.patch"<br>
S = "${WORKDIR}/git"<br>
-PR = "${INC_PR}.2"<br>
+PR = "${INC_PR}.0"<br>
<br>
</blockquote>
<br>
______________________________<u></u>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.<u></u>openembedded.org</a><br>
<a href="http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core" target="_blank">http://lists.linuxtogo.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openembedded-core</a><br>
</blockquote></div>