On Mon, Nov 19, 2012 at 4:12 PM, Saul Wold <span dir="ltr"><<a href="mailto:sgw@linux.intel.com" target="_blank">sgw@linux.intel.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On 11/19/2012 02:20 AM, Otavio Salvador wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Mon, Nov 19, 2012 at 3:54 AM, Saul Wold <<a href="mailto:sgw@linux.intel.com" target="_blank">sgw@linux.intel.com</a></div>
<div class="im">
<mailto:<a href="mailto:sgw@linux.intel.com" target="_blank">sgw@linux.intel.com</a>>> wrote:<br>
<br>
Rebase the patches due to macro name changes.<br>
<br>
Signed-off-by: Saul Wold <<a href="mailto:sgw@linux.intel.com" target="_blank">sgw@linux.intel.com</a><br></div>
<mailto:<a href="mailto:sgw@linux.intel.com" target="_blank">sgw@linux.intel.com</a>>><div class="im"><br>
...<br>
<br>
-PR = "${INC_PR}.0"<br>
-<br>
-SRC_URI[md5sum] = "<u></u>ba74b22c788a0c8547976b880cd02b<u></u>17"<br>
-SRC_URI[sha256sum] =<br>
"<u></u>2b59897864d6220ff20aa8eac64cac<u></u>8994e004898a1c0f899c8cb4d7b757<u></u>0b46"<br>
<br>
<br>
I find it hard to spot the checksums to be in the .inc file.<br>
<br>
I'd prefer to have them in the .bb recipes (even if in this case it'd be<br>
a duplication).<br>
<br>
</div></blockquote>
I am not sure why this is an issue, we already have about a dozen places where the SRC_URI and checksum info is located in the .inc file.</blockquote><div><br></div><div>We have two recipes and nothing force them to be always in sync so the checksum seems to be better placed in the .bb file</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
In case you would like to avoid the duplication (which I agree) you<br>
might before, or later, merge the native handle onto the cmake_<ver>.bb<br>
recipe.<br>
<br>
What do you think?<br>
<br>
</blockquote></div>
Looks like there are bigger issues with trying to merge native into the standard recipe, mostly due to the fact that the target recipe inherits cmake, while the native version does not.<br></blockquote><div><br></div><div>
Yes; I think I did a brief try in past and gave up.</div><div><br></div><div>So please, think about my comment above...</div><div><br></div></div>-- <br>Otavio Salvador O.S. Systems<br>E-mail: <a href="mailto:otavio@ossystems.com.br" target="_blank">otavio@ossystems.com.br</a> <a href="http://www.ossystems.com.br" target="_blank">http://www.ossystems.com.br</a><br>
Mobile: +55 53 9981-7854 <a href="http://projetos.ossystems.com.br" target="_blank">http://projetos.ossystems.com.br</a><br><br>