On Mon, Nov 26, 2012 at 7:37 AM, Martin Jansa <span dir="ltr"><<a href="mailto:martin.jansa@gmail.com" target="_blank">martin.jansa@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* so it will work look KERNEL_IMAGE<br>
* also we were recreating modules.tgz with every kernel build, but<br>
overwritting the same output file<br>
<br>
Signed-off-by: Martin Jansa <<a href="mailto:Martin.Jansa@gmail.com">Martin.Jansa@gmail.com</a>><br>
---<br>
meta/classes/kernel.bbclass | 7 ++++++-<br>
1 file changed, 6 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass<br>
index ee59aaf..9c70e70 100644<br>
--- a/meta/classes/kernel.bbclass<br>
+++ b/meta/classes/kernel.bbclass<br>
@@ -497,6 +497,10 @@ KERNEL_IMAGE_BASE_NAME ?= "${KERNEL_IMAGETYPE}-${PE}-${PV}-${PR}-${MACHINE}-${DA<br>
# Don't include the DATETIME variable in the sstate package signatures<br>
KERNEL_IMAGE_BASE_NAME[vardepsexclude] = "DATETIME"<br>
KERNEL_IMAGE_SYMLINK_NAME ?= "${KERNEL_IMAGETYPE}-${MACHINE}"<br>
+MODULE_TARBALL_BASE_NAME ?= "modules-${PE}-${PV}-${PR}-${MACHINE}-${DATETIME}.tgz"<br>
+# Don't include the DATETIME variable in the sstate package signatures<br>
+MODULE_TARBALL_BASE_NAME[vardepsexclude] = "DATETIME"<br>
+MODULE_TARBALL_SYMLINK_NAME ?= "modules-${MACHINE}.tgz"<br>
<br>
do_uboot_mkimage() {<br>
if test "x${KERNEL_IMAGETYPE}" = "xuImage" ; then<br>
@@ -526,7 +530,8 @@ addtask uboot_mkimage before do_install after do_compile<br>
kernel_do_deploy() {<br>
install -m 0644 ${KERNEL_OUTPUT} ${DEPLOYDIR}/${KERNEL_IMAGE_BASE_NAME}.bin<br>
if (grep -q -i -e '^CONFIG_MODULES=y$' .config); then<br>
- tar -cvzf ${DEPLOYDIR}/modules-${KERNEL_VERSION}-${PR}-${MACHINE}.tgz -C ${D} lib<br>
+ tar -cvzf ${DEPLOYDIR}/${MODULE_TARBALL_BASE_NAME} -C ${D} lib<br>
+ ln -sf ${MODULE_TARBALL_BASE_NAME}.bin ${MODULE_TARBALL_SYMLINK_NAME}<br></blockquote><div><br></div><div>Just a quick question, are there any concerns about existing users of the</div><div>old tgz name ? Obviously, if they were in oe-core, we'd know about them</div>
<div>and update them, but I have no idea myself how much (if anything) was based</div><div>on the old name. I'm not sure of the best practices oe-core/oe uses for cases</div><div>like this in the past, so I thought I'd ask. </div>
<div><br></div><div>The old shorter name was nice, but I agree that having it different than the image</div><div>name makes it non obvious how to associate the image and modules, and that's</div><div>a nice thing to fix.</div>
<div><br></div><div>Since we are already making a symlink, I guess we could consider a transnational</div><div>symlink with the old name ? (but then again, if the link is there, people will continue</div><div>to have dependencies on it and not update their own code).</div>
<div><br></div><div>Cheers,</div><div><br></div><div>Bruce</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
fi<br>
<br>
cd ${DEPLOYDIR}<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.0<br>
<br>
<br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core" target="_blank">http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br>"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"<br>
</div>