<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 10, 2013 at 11:27 PM, Martin Ertsaas <span dir="ltr"><<a href="mailto:martiert@gmail.com" target="_blank">martiert@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="adM">
</div><div bgcolor="#FFFFFF" text="#000000"><div class="adM"><div class="im">
On 01/10/13 15:15, Chris Larson wrote:
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Jan 10, 2013 at 1:50 AM,
Martin Ertsaas <span dir="ltr"><<a href="mailto:martiert@gmail.com" target="_blank">martiert@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>On mac, os.unlink can not be done to remove
directories, and so we have to<br>
explicitly use shutil.rmtree instead to support mac.<br>
</div>
</blockquote>
<div><br>
</div>
<div>As pointed out for the bitbake patch, the
functions can already handle this case if you pass
recurse=True, and mac isn't at all special in this
context.</div>
</div>
-- <br>
Christopher Larson</div>
</div>
</blockquote></div></div>
True. In this case though, I feel the patch is still valid though,
and that I should instead change the commit message. What I want
from this patch, as I see it again now, is to not duplicate the same
code in both bitbake and oe-core, when the oe-core function 'remove'
can just be calling bb.utils.remove. So personally I still want this
patch, I just wish to change the commit message to something sane.
Agreed?</div></blockquote></div><br>Agreed.<br>-- <br>Christopher Larson</div></div>