<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<div class="moz-cite-prefix">On 01/14/2013 08:10 PM, Saul Wold
wrote:<br>
</div>
<blockquote cite="mid:50F44A19.9040804@linux.intel.com" type="cite">On
01/14/2013 09:16 AM, Radu Moisan wrote:
<br>
<blockquote type="cite">
<br>
On 01/12/2013 01:23 AM, Saul Wold wrote:
<br>
<blockquote type="cite">On 01/08/2013 04:24 AM, Radu Moisan
wrote:
<br>
<blockquote type="cite">As Ross suggested I've done the
following changes to the previous set:
<br>
* added two patches (the first two) that address multiple
init
<br>
systems support,\
<br>
as in shifting from default hardcoded sysvinit to something
more
<br>
generic while
<br>
the default values still remains on sysvinit
<br>
* moved automatic setting of PREFERRED_PROVIDER_udev into
<br>
default_providers.inc
<br>
* removed ahavi-systemd since all it provided was service
files; now
<br>
service files
<br>
are pulled in by avahi-daemon
<br>
* also rebased on master
<br>
<br>
The following changes since commit
<br>
7e1f8faad0c4b6f490c26f87acc698dd6e002b15:
<br>
<br>
perl: Remove bashism from perl-tests.inc (2013-01-07
22:37:37 +0000)
<br>
<br>
are available in the git repository at:
<br>
<br>
git://git.yoctoproject.org/poky-contrib rmoisan/systemd
<br>
<a class="moz-txt-link-freetext" href="http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd">http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd</a>
<br>
<br>
Enrico Scholz (1):
<br>
systemd: move disable operation into prerm() script
<br>
<br>
Holger Hans Peter Freyther (2):
<br>
systemd: Make the main systemd files proper CONFFILES
<br>
systemd: Introduce a create-volatile to create tmp
directories
<br>
</blockquote>
White space 4 spaces vs tab
<br>
</blockquote>
<br>
Fixed.
<br>
<br>
<blockquote type="cite">
<br>
<blockquote type="cite">
<br>
Khem Raj (1):
<br>
systemd: Fix build when base_libdir is not /lib
<br>
<br>
Martin Donnelly (2):
<br>
cgroups: Add INSANE_SKIP to avoid warning about .so file
<br>
systemd: Remove sysvinit mount related services if
systemd is enabled
<br>
<br>
Martin Jansa (2):
<br>
systemd: fix FILESPATH to find systemctl
<br>
systemd: add PACKAGES_DYNAMIC
<br>
<br>
Radu Moisan (13):
<br>
default-distrovars: Add DISTRO_FEATURES_INITMAN to
DISTRO_FEATURES
<br>
default-providers: Automatically set
PREFERRED_PROVIDER_udev
<br>
systemd: initial integration
<br>
</blockquote>
I believe this was mentioned before, but can you avoid making
white
<br>
space changes, you seem to have changed tabs (which we use
tabs for
<br>
shell based functions and 4 spaces for python based functions)
<br>
<br>
Specifically, I saw some changes in wpa-supplicant-1.0.inc,
busybox,
<br>
dropbear, initscripts
<br>
<br>
</blockquote>
Reviewed those files and cleaned them up to comply.
<br>
<br>
</blockquote>
I am still seeing white space changes, as mentioned before if you
want to cleanup white space changes, make that a separate and
distinct patch, so for instance in dropbear you un-indented some
SRC_URIs, that should be a distinct patch with white space changes
only separate from the addition of the dropbear*.service files.
<br>
<br>
I know I might be getting a little nit-picky, but it's about
readability and understanding the change sets, I just stop looking
because it's hard to see the changes clearly.
<br>
<br>
So please check you whitespace and sent a seperate whitespace
fixup patch.
<br>
</blockquote>
<br>
You need to get to an understanding with Ross. He suggested to get
rid if white space patches, and squash them so that only relevant
changes would appear in the history. <br>
About the spaces vs tab problem, I tried to fix that yesterday in
the files you mentioned, and indeed I fixed it for the entire file.
I understand it would make reviewing harder, but you can always use
<font face="monospace">-w</font> option with <font face="monospace">git
show</font> or <font face="monospace">git diff</font> to ignore
white spaces.<br>
<br>
Radu<br>
</body>
</html>