<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 31, 2013 at 12:50 PM, Chris Larson <span dir="ltr"><<a href="mailto:clarson@kergoth.com" target="_blank">clarson@kergoth.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><div class="gmail_quote">On Thu, Jan 31, 2013 at 12:11 PM, Saul Wold <span dir="ltr"><<a href="mailto:sgw@linux.intel.com" target="_blank">sgw@linux.intel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>- rdepends = d.getVar('RDEPENDS_%s' % pkg, True)<br>
- rdepends = rdepends + ' ' + d.getVar('MLPREFIX') + "hicolor-icon-theme"<br>
- d.setVar('RDEPENDS_%s' % pkg, rdepends)<br>
+ rdepends = ' ' + d.getVar('MLPREFIX') + "hicolor-icon-theme"<br>
+ d.appendVar('RDEPENDS_%s' % pkg, rdepends)</div></blockquote></div><br></div>The new version isn't using a getVar of the old rdepends at all, so it's just replacing it every time. Is that really what you intended here? Wouldn't a getVar() or '' be a better approach? Further, the '' + d.getVar('MLPREFIX') is pointless if you aren't including the original value, as it adds a separator to the beginning when there's nothing to separate.</blockquote>
</div><br>Erm, ignore this, I'm apparently blind as a bat if I can't see 'appendVar' :)<br>-- <br>Christopher Larson</div></div>