<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 25, 2013 at 9:54 AM, Richard Purdie <span dir="ltr"><<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":17x">If an error occurs in subprocess.call() we currently don't catch it. In particular<br>
we have issues where debugedit is segfaulting unnoticed. This fixes up<br>
various code paths to catch the errors.</div></blockquote></div><br>Well spotted, at a minimum we should be using check_call(), so an unanticipated failure results in an uncaught exception, but explicitly checking retval makes sense as well.<br>
-- <br>Christopher Larson</div></div>