<div dir="ltr"><br><div class="gmail_extra">On Wed, Mar 20, 2013 at 4:30 PM, Bruce Ashfield <span dir="ltr"><<a href="mailto:bruce.ashfield@gmail.com" target="_blank">bruce.ashfield@gmail.com</a>></span> wrote:<br><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Wed, Mar 20, 2013 at 10:55 AM, Anders Roxell <<a href="mailto:anders.roxell@gmail.com">anders.roxell@gmail.com</a>> wrote:<br>
><br>
><br>
><br>
> On Wed, Mar 20, 2013 at 2:42 PM, Bruce Ashfield <<a href="mailto:bruce.ashfield@gmail.com">bruce.ashfield@gmail.com</a>><br>
> wrote:<br>
>><br>
>> On Wed, Mar 20, 2013 at 9:22 AM, <<a href="mailto:anders.roxell@gmail.com">anders.roxell@gmail.com</a>> wrote:<br>
>> > From: Anders Roxell <<a href="mailto:anders.roxell@enea.com">anders.roxell@enea.com</a>><br>
>> ><br>
>> > In mainline kernel 3.7-rc1 (hash:abbf1590de22a6d22)<br>
>> > The path include/linux/version.h was updated to<br>
>> > include/generated/uapi/linux/version.h<br>
>><br>
>> It's true that uapi now holds the generated version.h, but what build<br>
>> error were you seeing without this change in place ?<br>
><br>
><br>
> We were trying to build linx<br>
> (<a href="http://linx.sourceforge.net/linxdoc/doc/index.html" target="_blank">http://linx.sourceforge.net/linxdoc/doc/index.html</a>)<br>
> Please let me know if it is better to rewrite linx or include this patch?<br>
<br>
</div>My concern is that as a list of alternatives builds up over time, that don't<br>
necessarily use the same format of the linux version, you'll end up with<br>
applications that are making the wrong decisions if a fallback is used. Having<br>
a clear public / exported file, and throwing errors if it doesn't exist would<br>
ensure consistent behaviour (granted annoying if you get the error when you<br>
think you shouldn't).<br>
<br>
If you look at the code in get_kernelversion() it shouldn't even work if<br>
version.h is used versus utsrelease.h. I'd be inclined to suggest the<br>
removal of the existing version.h fallback, versus adding another.<br>
<br>
You might not even need to modify the application code to fix this. What<br>
are the dependencies of your recipe that would allow for utsrelease.h<br>
to not be generated when the build calls get_kernelversion ?<br>
<br></blockquote><div style><br></div><div style>Sorry for the late response!</div><div style>I agree with you that its better to use utsrelease.h rather than depending on version.h.</div><div style><br></div><div style>
We have added a patch for the linx source to solve this.</div><div style><br></div><div style>Thank you very much for the help and support!</div><div style><br></div><div style>With kind regards,</div><div style>Anders</div>
<div style> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Cheers,<br>
<br>
Bruce<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> Regards,<br>
> Anders<br>
><br>
>><br>
>> utsrelease.h is<br>
>> still created where it has been for some time, and should be what is<br>
>> typically used for any version checks.<br>
>><br>
>> Cheers,<br>
>><br>
>> Bruce<br>
>><br>
>><br>
>><br>
>> ><br>
>> > Signed-off-by: Anders Roxell <<a href="mailto:anders.roxell@enea.com">anders.roxell@enea.com</a>><br>
>> > ---<br>
>> > meta/classes/linux-kernel-base.bbclass | 3 +++<br>
>> > 1 files changed, 3 insertions(+), 0 deletions(-)<br>
>> ><br>
>> > diff --git a/meta/classes/linux-kernel-base.bbclass<br>
>> > b/meta/classes/linux-kernel-base.bbclass<br>
>> > index 4f2b0a4..b7d0ffa 100644<br>
>> > --- a/meta/classes/linux-kernel-base.bbclass<br>
>> > +++ b/meta/classes/linux-kernel-base.bbclass<br>
>> > @@ -8,6 +8,9 @@ def get_kernelversion(p):<br>
>> > fn = p + '/include/generated/utsrelease.h'<br>
>> > if not os.path.isfile(fn):<br>
>> > fn = p + '/include/linux/version.h'<br>
>> > + if not os.path.isfile(fn):<br>
>> > + # after 3.7-rc1<br>
>> > + fn = p + '/include/generated/uapi/linux/version.h'<br>
>> ><br>
>> > import re<br>
>> > try:<br>
>> > --<br>
>> > 1.7.5.4<br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > Openembedded-core mailing list<br>
>> > <a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.openembedded.org</a><br>
>> > <a href="http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core" target="_blank">http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core</a><br>
>><br>
>><br>
>><br>
>> --<br>
>> "Thou shalt not follow the NULL pointer, for chaos and madness await<br>
>> thee at its end"<br>
><br>
><br>
<br>
<br>
<br>
--<br>
"Thou shalt not follow the NULL pointer, for chaos and madness await<br>
thee at its end"<br>
</div></div></blockquote></div><br></div></div>