<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 8, 2013 at 7:14 PM, Robert Yang <span dir="ltr"><<a href="mailto:liezhi.yang@windriver.com" target="_blank">liezhi.yang@windriver.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 05/08/2013 08:03 PM, Mike Looijmans wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 05/08/2013 11:06 AM, Robert Yang wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The bb.fatal() is defined as:<br>
<br>
def fatal(*args):<br>
logger.critical(''.join(args))<br>
sys.exit(1)<br>
<br>
So anything after bb.fatal() in the same code block doesn't have any<br>
effect, e.g.:<br>
<br>
bb.fatal("%s_%s: %s" % (var, pkg, e))<br>
raise e<br>
<br>
The "raise e" should be removed.<br>
</blockquote>
<br>
Just some random thoughts that occurred to me when I read this:<br>
<br>
</blockquote>
<br></div>
Hi Mike, thanks for your comments, but the "raise sys.exit(1)" doesn't raise<br>
anything, e.g.:<br>
<br>
import sys<br>
<br>
def fatal():<br>
sys.exit(1)<br>
<br>
try:<br>
raise fatal()<br>
except Exception as e:<br>
raise e<br>
<br>
I think that the "raise fatal()" equals to "fatal()" here.</blockquote></div><br>He didn't say raise sys.exit(1), he said sys.exit(1) is equivalent to raise SystemExit(1), which it is.<br>-- <br>Christopher Larson</div>
</div>