<div dir="ltr">On 23 May 2013 02:33, Burton, Ross <span dir="ltr"><<a href="mailto:ross.burton@intel.com" target="_blank">ross.burton@intel.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi Jonathan<br>
<div class="im"><br>
On 22 May 2013 02:47, Jonathan Liu <<a href="mailto:net147@gmail.com">net147@gmail.com</a>> wrote:<br>
> This adds the /run directory from the Filesystem Hierarchy Standard 3.0<br>
> Draft [1] and refactors the filesystem as follows:<br>
<br>
</div>Good start!<br>
<div class="im"><br>
> - Remove /var/run from dbus package as it is created on startup<br>
> - Remove /var/volatile/run/resolvconf/interface from resolvconf package<br>
> as resolvconf package uses /etc/resolvconf/run/interface<br>
<br>
</div>Can these be separate patches, as they're essentially unrelated cleanups.<br></blockquote><div style>Ok.</div><div style> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Please also drop all PR changes, they're not needed in oe-core.<br></blockquote><div><br></div><div style>Ok. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class="im"><br>
> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt<br>
> index becb85c..c829bec 100644<br>
> --- a/meta/files/fs-perms.txt<br>
> +++ b/meta/files/fs-perms.txt<br>
> @@ -45,15 +45,14 @@ ${oldincludedir} 0755 root root true 0644 root root<br>
><br>
> # Items from base-files<br>
> # Links<br>
> -${localstatedir}/run link volatile/run<br>
> +${localstatedir}/run link /run<br>
> ${localstatedir}/log link volatile/log<br>
> -${localstatedir}/lock link volatile/lock<br>
> +${localstatedir}/lock link /run/lock<br>
> ${localstatedir}/tmp link volatile/tmp<br>
><br>
> # Special permissions from base-files<br>
> # Set 1777<br>
> /tmp 01777 root root false - - -<br>
> -${localstatedir}/volatile/lock 01777 root root false - - -<br>
> ${localstatedir}/volatile/tmp 01777 root root false - - -<br>
<br>
</div>Nothing appears to sets mode 1777 on /run/lock. Then again Fedora<br>
thinks that 0755 is sufficient, although Debian uses 1777. We should<br>
probably keep the permissions as 1777.<br></blockquote><div>For sysvinit case, /run/lock is created with root:root owner and 1777 permissions by populate-volatiles.sh.</div><div>For systemd case, /run/lock is created with root:root owner and 0755 permissions by /usr/lib/tmpfiles.d/legacy.conf - <a href="http://cgit.freedesktop.org/systemd/systemd/tree/tmpfiles.d/legacy.conf">http://cgit.freedesktop.org/systemd/systemd/tree/tmpfiles.d/legacy.conf</a>. Presumably any system using the stock systemd legacy.conf, it would be using 0755 permissions. This is true on Arch Linux and Fedora for example.</div>
<div>I would generally prefer to stick with permissions from systemd upstream.</div><div>What is your opinion on the matter?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc<br>
index 2be5bda..8055824 100644<br>
--- a/meta/recipes-core/dbus/dbus.inc<br>
+++ b/meta/recipes-core/dbus/dbus.inc<br>
<div class="im">@@ -101,9 +101,9 @@ do_install() {<br>
> ${D}${sysconfdir}/default/volatiles/99_dbus<br>
<br>
<br>
- mkdir -p ${D}${localstatedir}/run/dbus ${D}${localstatedir}/lib/dbus<br>
+ mkdir -p ${D}${localstatedir}/lib/dbus<br>
<br>
</div>Presumably dbus will create /run/dbus if required?<br>
<span class=""><font color="#888888"><br>
Ross<br>
</font></span></blockquote></div><div class="gmail_extra"><div class="gmail_extra">/run/dbus is created automatically on boot.</div><div class="gmail_extra">For sysvinit case, it is created by populate-volatiles.sh which also sets messagebus:messagebus owner.</div>
<div class="gmail_extra">For systemd case, it is created when dbus.socket (a dependency of dbus.service) is started by systemd. dbus.socket implicitly creates it when specifying:</div></div></div><div class="gmail_extra" style>
[Socket]</div><div class="gmail_extra" style>ListenStream=/var/run/dbus/system_bus_socket</div><div class="gmail_extra" style><br></div><div class="gmail_extra" style>Regards,</div><div class="gmail_extra" style>Jonathan</div>
</div>