<p dir="ltr">On 24 Jun 2013 07:28, <<a href="mailto:jackie.huang@windriver.com">jackie.huang@windriver.com</a>> wrote:<br>
><br>
> From: Jackie Huang <<a href="mailto:jackie.huang@windriver.com">jackie.huang@windriver.com</a>><br>
><br>
> The code relies on hardware specific memory locations to access<br>
> and modify the keyboard repeat rate. It also requires read/write<br>
> access to /dev/port which doesn't exist on every architecture's<br>
> root fs. The defect was raised for Qemu PowerPC but it also fails on<br>
> ARM. The keyboard emulation in qemuppc is for an ADB (Apple Desktop Bus)<br>
> device and not compatible with an Intel driver. There's also no<br>
> indication in the documentation that the code should work on<br>
> anything other than Intel architecture but it also works on MIPS.<br>
></p>
<p dir="ltr">> ++#if !( defined(__i386__) \<br>
> ++ || defined(__x86_64__) \<br>
> ++ || defined(__mips__) \<br>
> ++ || defined(__sparc___))<br>
> ++<br>
> ++ fprintf(stderr,<br>
> ++ "ERROR: %s should only be used on MIPS, x86 and Sparc archicture boards\n", basename(argv[0]));<br>
> ++ exit(1);<br>
> ++#endif</p>
<p dir="ltr">Would it be better to detect the target platform in the build system and skip building the kbdrate program for architectures it won't work on rather than building and installing a known broken program?</p>
<p dir="ltr">> ++ set_progname(argv[0]);<br>
> + set_progname(argv[0]);</p>
<p dir="ltr">Accidental repeat?</p>
<p dir="ltr">--</p>
<p dir="ltr">Paul Barker</p>
<p dir="ltr">Email: <a href="mailto:paul@paulbarker.me.uk">paul@paulbarker.me.uk</a><br>
<a href="http://www.paulbarker.me.uk">http://www.paulbarker.me.uk</a></p>