<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 19, 2013 at 10:39 AM, André Draszik <span dir="ltr"><<a href="mailto:andre.draszik@linaro.org" target="_blank">andre.draszik@linaro.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div id=":1fq" style="overflow:hidden">We are currently getting build failures of projects that rely on<br>
being able to access DirectFB's internal include directories, as<br>
returned via pkg-config, since the include paths returned by<br>
pkg-config are incomplete.<br>
<br>
The reason for that is the patch that is being removed with this<br>
change. It modified the cflags returned by pkg-config in an<br>
incorrect way, causing us to miss important include paths:<br>
<br>
For reference, pkg-config output with incorrect patch applied:<br>
ad@bril0118 #513 ~> pkg-config --cflags directfb-internal<br>
-D_GNU_SOURCE -D_REENTRANT -I<builddir>/tmp/sysroots/<machine>/usr/include/directfb -I<builddir>/tmp/sysroots/<machine>/usr/include<br>
<br>
Now, with the incorrect patch removed, the output is as expected:<br>
ad@bril0118 #514 ~> pkg-config --cflags directfb-internal<br>
-D_GNU_SOURCE -D_REENTRANT -I<builddir>/tmp/sysroots/<machine>/usr/include/directfb-internal -I<builddir>/tmp/sysroots/<machine>/usr/include/directfb<br>
<br>
Overall, the removed patch is not needed - pkg-config does the right<br>
thing these days and we can simply use the correctly working upstream<br>
versions of all DirectFB .pc files.<br>
<br>
Signed-off-by: André Draszik <<a href="mailto:andre.draszik@linaro.org">andre.draszik@linaro.org</a>><br></div></blockquote></div><br>i reviewed and tested this patch against a QT4e image build. it looks good to me, and that offending patch being removed seems to come from quite ancient stuff. </div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Tested-by: Nicolas Dechesne <<a href="mailto:nicolas.dechesne@linaro.org">nicolas.dechesne@linaro.org</a>><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">
any chance this can get into 'dylan', too?</div><div class="gmail_extra"><br></div><div class="gmail_extra"><br></div><div class="gmail_extra"><br></div></div>