<br><br><div class="gmail_quote">On Wed, Aug 7, 2013 at 7:34 AM, Burton, Ross <span dir="ltr"><<a href="mailto:ross.burton@intel.com" target="_blank">ross.burton@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<div class="im"><br>
On 7 August 2013 15:17, Matt Ranostay <<a href="mailto:mranostay@gmail.com">mranostay@gmail.com</a>> wrote:<br>
> Added ACPICA package which enables viewing/editing/compiling<br>
> of ACPI tables.<br>
<br>
</div>Is this really general-purpose enough to be suitable for oe-core, or<br>
would it be more suited to meta-oe or some other layer?<br>
<br></blockquote><div>Probably correct to be in meta-oe or another layer since only x86 and some ARM platforms use ACPI as of now.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
> +PR = "r0"<br>
<br>
Remove this line, r0 is the default.<br>
<div class="im"><br>
+LIC_FILES_CHKSUM =<br>
"file://${S}/source/include/aclocal.h;endline=42;md5=07fbd4e514c75e140a19e3ab508f763d"<br>
<br>
</div>${S} is default, so in general people do file://sources/...<br>
<div class="im"><br>
> +SRC_URI = "<a href="https://acpica.org/sites/acpica/files/acpica-unix2-${PV}.tar.gz" target="_blank">https://acpica.org/sites/acpica/files/acpica-unix2-${PV}.tar.gz</a>"<br>
<br>
</div>Fetching that here with wget produces:<br>
<br>
ERROR: The certificate of ‘<a href="http://acpica.org" target="_blank">acpica.org</a>’ is not trusted.<br>
<br></blockquote><div><br>Seems StartCom Ltd. isn't a trusted CA or just not in the keystore by default.<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Someone should tell them...<br>
<br>
> +inherit autotools<br>
<br>
The recipe doesn't use autotools, so you should drop this inherit.<br>
<div class="im"><br>
> +do_install() {<br>
> + oe_runmake INSTALLFLAGS="-m 555"<br>
> +}<br>
<br>
</div>That's just running 'make INSTALLFLAGS="-m 555"'. You'll need to tell<br>
it to run the right target for install, and to pass ${D} somehow so<br>
the makefile doesn't try and write to /usr directly.<br>
<span class="HOEnZb"><font color="#888888"><br></font></span></blockquote><div>Gah good catch. Will fix up and resubmit.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888">
Ross<br>
</font></span></blockquote></div><br>