<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 08/08/2013 10:23 AM, Khem Raj wrote:<br>
</div>
<blockquote
cite="mid:CAMKF1sqwzMQb5W2+2VdASiDi2J+R_9gNWAFU0dAftqBtTgVipA@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<br>
<br>
On Wednesday, August 7, 2013, ChenQi <<a moz-do-not-send="true"
href="mailto:Qi.Chen@windriver.com">Qi.Chen@windriver.com</a>>
wrote:<br>
> On 08/07/2013 10:18 PM, Chris Larson wrote:<br>
><br>
> On Wed, Aug 7, 2013 at 1:08 AM, <<a moz-do-not-send="true"
href="mailto:Qi.Chen@windriver.com">Qi.Chen@windriver.com</a>>
wrote:<br>
>><br>
>> From: Chen Qi <<a moz-do-not-send="true"
href="mailto:Qi.Chen@windriver.com">Qi.Chen@windriver.com</a>><br>
>><br>
>> The init script for irda writes configuration items to
/etc/sysconfig/irda<br>
>> if that file is not available in system. But it's
actually not necessary,<br>
>> the behavior doesn't change whether the init script
writes to the file or not.<br>
>><br>
>> Considering it issues error messages in case of a
read-only rootfs, I delete<br>
>> the writing process.<br>
>><br>
>> [YOCTO #4103]<br>
>> [YOCTO #4886]<br>
>><br>
>> Signed-off-by: Chen Qi <<a moz-do-not-send="true"
href="mailto:Qi.Chen@windriver.com">Qi.Chen@windriver.com</a>><br>
><br>
> This is a start, but is incomplete, from what I can tell. As
mentioned in the other thread, the startup script shouldn't be
using /etc/sysconfig/ at all, in any form. We use /etc/default/
for our startup script config files, not /etc/sysconfig/.<br>
><br>
> Yeah, I agree with you.<br>
> But when I checked the irda source code, I saw that it
actually could ship its own init script
(irda-utils-xxx/etc/irda.rc). And I think our init script is
derived from this one. In its own init script, /etc/sysconfig is
used.<br>
> (Of course, I still think /etc/default is a better location
for its configuration file.)<br>
><br>
><br>
> Also, the purpose of this block was clearly to implement a
default configuration, yet the recipe isn't altered to ship a
default configuration to provide equivalent functionality.<br>
><br>
> In its source code, there's a default configuration file, and
we don't use that. I think there might be a reason.<br>
> So I'm not sure about this one.<br>
><br>
> If you have a patch to fix the irda issue properly, send it
out and I'll rebase my remote branch and drop this one.<br>
<br>
Whether Chris has a patch or not this patch in its form should be
dropped since there is a better way to do it<br>
<br>
</blockquote>
<br>
Shipping a default configuration file or using /etc/default as the
configuration directory? Or something else?<br>
<br>
//Chen Qi<br>
<br>
<blockquote
cite="mid:CAMKF1sqwzMQb5W2+2VdASiDi2J+R_9gNWAFU0dAftqBtTgVipA@mail.gmail.com"
type="cite">><br>
> Best Regards,<br>
> Chen Qi<br>
><br>
><br>
> --<br>
> Christopher Larson<br>
> clarson at kergoth dot com<br>
> Founder - BitBake, OpenEmbedded, OpenZaurus<br>
> Maintainer - Tslib<br>
> Senior Software Engineer, Mentor Graphics<br>
>
</blockquote>
<br>
</body>
</html>