<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 20, 2013 at 8:23 AM, Otavio Salvador <span dir="ltr"><<a href="mailto:otavio@ossystems.com.br" target="_blank">otavio@ossystems.com.br</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Mon, Aug 19, 2013 at 11:48 PM, Christopher Larson <<a href="mailto:kergoth@gmail.com">kergoth@gmail.com</a>> wrote:<br>
> From: Christopher Larson <<a href="mailto:chris_larson@mentor.com">chris_larson@mentor.com</a>><br>
><br>
> - path normalization ('normalize' flag, defaults to enabled)<br>
> - existence verification for paths we know should exist ('mustexist' flag)<br>
> - supports clean handling of relative paths ('relativeto' flag)<br>
><br>
> Signed-off-by: Christopher Larson <<a href="mailto:chris_larson@mentor.com">chris_larson@mentor.com</a>><br>
<br>
</div>Great addition :-)<br>
<div class="im"><br>
> ---<br>
> meta/lib/oe/types.py | 18 ++++++++++++++++++<br>
> 1 file changed, 18 insertions(+)<br>
><br>
> diff --git a/meta/lib/oe/types.py b/meta/lib/oe/types.py<br>
> index 5dac9de..7f47c17 100644<br>
> --- a/meta/lib/oe/types.py<br>
> +++ b/meta/lib/oe/types.py<br>
> @@ -1,4 +1,7 @@<br>
> +import errno<br>
> import re<br>
> +import os<br>
> +<br>
<br>
</div>No need for another new and empty line here.<br>
<br>
Rest of code looks alright :-)</blockquote></div><br>Good call, will tweak slightly and re-submit. Thanks for the review.<br>-- <br>Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>
Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics
</div></div>