<br><br>On Tuesday, September 24, 2013,   wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Roy Li &lt;<a href="javascript:;" onclick="_e(event, &#39;cvml&#39;, &#39;rongqing.li@windriver.com&#39;)">rongqing.li@windriver.com</a>&gt;<br>

<br>
It is correct behaviours to output help and version information,<br>
and should return 0;<br>
When input parameter is invalid, print help information and exit.</blockquote><div><br></div><div>This can cause gripes for systems who have scripted the old behavior</div><div>And since it&#39;s a user visible change I would suggest to get it accepted upstream before </div>
<div>It&#39;s applied in openembedded </div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Signed-off-by: Roy Li &lt;<a href="javascript:;" onclick="_e(event, &#39;cvml&#39;, &#39;rongqing.li@windriver.com&#39;)">rongqing.li@windriver.com</a>&gt;<br>
---<br>
 meta/recipes-devtools/makedevs/makedevs-1.0.0/makedevs.c |    9 ++++++---<br>
 1 file changed, 6 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/meta/recipes-devtools/makedevs/makedevs-1.0.0/makedevs.c b/meta/recipes-devtools/makedevs/makedevs-1.0.0/makedevs.c<br>
index cc3707b..5d2c45b 100644<br>
--- a/meta/recipes-devtools/makedevs/makedevs-1.0.0/makedevs.c<br>
+++ b/meta/recipes-devtools/makedevs/makedevs-1.0.0/makedevs.c<br>
@@ -465,8 +465,8 @@ int main(int argc, char **argv)<br>
                                error_msg_and_die(&quot;%s: not a proper device table file&quot;, optarg);<br>
                        break;<br>
                case &#39;h&#39;:<br>
-                       fprintf(stderr, helptext);<br>
-                       exit(1);<br>
+                       printf(helptext);<br>
+                       exit(0);<br>
                case &#39;r&#39;:<br>
                case &#39;d&#39;:                               /* for compatibility with mkfs.jffs, genext2fs, etc... */<br>
                        if (rootdir != default_rootdir) {<br>
@@ -476,8 +476,11 @@ int main(int argc, char **argv)<br>
                        break;<br>
<br>
                case &#39;v&#39;:<br>
-                       fprintf(stderr, &quot;makedevs revision %.*s\n&quot;,<br>
+                       printf(&quot;makedevs revision %.*s\n&quot;,<br>
                                        (int) strlen(revtext) - 13, revtext + 11);<br>
+                       exit(0);<br>
+               default:<br>
+                       fprintf(stderr, helptext);<br>
                        exit(1);<br>
                }<br>
        }<br>
--<br>
1.7.10.4<br>
<br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="javascript:;" onclick="_e(event, &#39;cvml&#39;, &#39;Openembedded-core@lists.openembedded.org&#39;)">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote>