<br><br>On Tuesday, October 22, 2013, Riku Voipio <<a href="mailto:riku.voipio@linaro.org">riku.voipio@linaro.org</a>> wrote:<br>> On 22 October 2013 01:42, Khem Raj <<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>> wrote:<br>
>> On Monday, October 21, 2013, Riku Voipio <<a href="mailto:riku.voipio@linaro.org">riku.voipio@linaro.org</a>> wrote:<br>>>> Cleanups for ltp:<br>>>><br>>>> 1. Instead of using giturl like in Anders's patch use the sourceforge<br>
>>> mirror URL.<br>>><br>>> whats wrong with git url ?<br>><br>> The previous LTP version in OE used to have tarball url, so I was just<br>> changing it back. I guess the main functional difference is that git<br>
> url won't have checksums for downloads? Using tarball downloads over<br>> git checkouts is being more kind to upstream hosting. Mostly a matter<br>> of taste, or does OE-core have some preferred policy?<br>
<br>i dont think there is any preference i was thinking if git had issues<br><br>><br>> Riku<br>><br>>>> 2. remove to the manual unpack rule and just set S variable to source<br>>>> directory.<br>
>>> 3. Follow the OE style guide for variable order.<br>>>> ---<br>>>> meta/recipes-extended/ltp/<a href="http://ltp_20130904.bb">ltp_20130904.bb</a> | 50<br>>>> +++++++++++++------------------<br>
>>> 1 file changed, 21 insertions(+), 29 deletions(-)<br>>>><br>>>> diff --git a/meta/recipes-extended/ltp/<a href="http://ltp_20130904.bb">ltp_20130904.bb</a><br>>>> b/meta/recipes-extended/ltp/<a href="http://ltp_20130904.bb">ltp_20130904.bb</a><br>
>>> index 5e10448..43fe780 100644<br>>>> --- a/meta/recipes-extended/ltp/<a href="http://ltp_20130904.bb">ltp_20130904.bb</a><br>>>> +++ b/meta/recipes-extended/ltp/<a href="http://ltp_20130904.bb">ltp_20130904.bb</a><br>
>>> @@ -21,44 +21,21 @@ LIC_FILES_CHKSUM =<br>>>> "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \<br>>>><br>>>> DEPENDS = "attr libaio libcap acl openssl"<br>>>><br>
>>> -SRC_URI = "git://<a href="http://github.com/linux-test-project/ltp.git">github.com/linux-test-project/ltp.git</a>"<br>>>> +SRC_URI =<br>>>> "${SOURCEFORGE_MIRROR}/project/ltp/LTP%20Source/ltp-${PV}/ltp-full-${PV}.tar.bz2<br>
>>> \<br>>>> + "<br>>>><br>>>> -SRCREV = "a8c42db5f9314211811c36275a21f83902830dc5"<br>>>> -S = "${WORKDIR}/git"<br>>>> +SRC_URI[md5sum] = "0cf2ccb7199f8318d413c62a085629f0"<br>
>>> +SRC_URI[sha256sum] =<br>>>> "662c3661a4d1bfbf3187d0835f35e613b43eedc35a840e3283e378a19606ee0b"<br>>>><br>>>> export prefix = "/opt/ltp"<br>>>> export exec_prefix = "/opt/ltp"<br>
>>><br>>>> inherit autotools<br>>>><br>>>> -RDEPENDS_${PN} = "perl e2fsprogs-mke2fs"<br>>>> -<br>>>> -FILES_${PN}-dbg += "/opt/ltp/runtest/.debug"<br>
>>> -FILES_${PN}-dbg += "/opt/ltp/testcases/bin/.debug"<br>>>> -FILES_${PN}-dbg += "/opt/ltp/testcases/bin/*/bin/.debug"<br>>>> -FILES_${PN}-dbg += "/opt/ltp/testcases/bin/*/test/.debug"<br>
>>> -FILES_${PN}-dbg += "/opt/ltp/scenario_groups/.debug"<br>>>> -FILES_${PN}-dbg += "/opt/ltp/testscripts/.debug"<br>>>> -FILES_${PN}-dbg += "/opt/ltp/testscripts/open_posix_testsuite/.debug"<br>
>>> -<br>>>> -FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a"<br>>>> -<br>>>> -FILES_${PN} += "/opt/ltp/* /opt/ltp/runtest/* /opt/ltp/scenario_groups/*<br>>>> /opt/ltp/testcases/bin/* /opt/ltp/testcases/bin/*/bin/*<br>
>>> /opt/ltp/testscripts/* /opt/ltp/testcases/open_posix_testsuite/*<br>>>> /opt/ltp/testcases/open_posix_testsuite/conformance/*<br>>>> /opt/ltp/testcases/open_posix_testsuite/Documentation/*<br>
>>> /opt/ltp/testcases/open_posix_testsuite/functional/*<br>>>> /opt/ltp/testcases/open_posix_testsuite/include/*<br>>>> /opt/ltp/testcases/open_posix_testsuite/scripts/*<br>>>> /opt/ltp/testcases/open_posix_testsuite/stress/*<br>
>>> /opt/ltp/testcases/open_posix_testsuite/tools/*"<br>>>> +S = "${WORKDIR}/ltp-full-${PV}"<br>>>><br>>>> TARGET_CC_ARCH += "${LDFLAGS}"<br>>>><br>>>> -do_unpack_append() {<br>
>>> - bb.build.exec_func('do_extract_tarball', d)<br>>>> -}<br>>>> -<br>>>> -do_extract_tarball() {<br>>>> - if test -f ${WORKDIR}/ltp-full-${PV} ; then<br>>>> - tar x --no-same-owner -f ${WORKDIR}/ltp-full-${PV} -C<br>
>>> ${WORKDIR}<br>>>> - rm -rf ${WORKDIR}/ltp-${PV}<br>>>> - mv ${WORKDIR}/ltp-full-${PV} ${WORKDIR}/ltp-${PV}<br>>>> - fi<br>>>> -}<br>>>> -<br>
>>> do_install(){<br>>>> install -d ${D}/opt/ltp/<br>>>> oe_runmake DESTDIR=${D} SKIP_IDCHECK=1 install<br>>>> @@ -66,10 +43,25 @@ do_install(){<br>>>> # Copy POSIX test suite into ${D}/opt/ltp/testcases by manual<br>
>>> cp -r testcases/open_posix_testsuite ${D}/opt/ltp/testcases<br>>>><br>>>> - # We